Attachment 126189 Details for Bug 24850 – Bug 24850: (follow-up) Add tests for invalid RFC3339 dates

[patch] Bug 24850: (follow-up) Add tests for invalid RFC3339 dates

Bug-24850-follow-up-Add-tests-for-invalid-RFC3339-.patch (text/plain), 1.23 KB, created by Martin Renvoize (ashimema) on 2021-10-13 12:39:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-10-13 12:39:03 UTC

Size: 1.23 KB

patch

obsolete

>From 73d8078ebb8137ebe8d3e5707582e31f382beb25 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 8 Feb 2021 15:46:35 +0100
>Subject: [PATCH] Bug 24850: (follow-up) Add tests for invalid RFC3339 dates
>
>Make this failure explicit, otherwise we get a "bad plan" failure.
>---
> t/DateUtils.t | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/t/DateUtils.t b/t/DateUtils.t
>index 97daa555bf..274c3f3975 100755
>--- a/t/DateUtils.t
>+++ b/t/DateUtils.t
>@@ -137,12 +137,10 @@ cmp_ok( $dt0->epoch(), 'eq', '1325462399', 'dt_from_string handles seconds with
> $dt0 = dt_from_string( '2012-01-01T23:59:59.999+02:00', 'rfc3339' );
> cmp_ok( $dt0->epoch(), 'eq', '1325455199', 'dt_from_string handles seconds with 3 decimal places and a timezone' );
> 
>-try {
>+eval {
>     $dt0 = dt_from_string( '2012-01-01T23:59:59.999Z+02:00', 'rfc3339' );
>-}
>-catch {
>-    like( $_, qr/.*does not match the date format $rfc3339$.*/, 'dt_from_string should die when passed a bad date string' );
> };
>+like( $@, qr/.*does not match the date format $rfc3339$.*/, 'dt_from_string should die when passed a bad date string' );
> 
> # Return undef if passed mysql 0 dates
> $dt0 = dt_from_string( '0000-00-00', 'iso' );
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24850: 100585 | 100586 | 100587 | 100592 | 100593 | 100594 | 100595 | 100678 | 100679 | 100680 | 100681 | 100881 | 100901 | 100902 | 100903 | 100904 | 100905 | 101803 | 101804 | 101805 | 101806 | 101807 | 101808 | 101837 | 101838 | 101839 | 101840 | 101841 | 101842 | 101843 | 101844 | 115851 | 115852 | 115853 | 115854 | 115855 | 115856 | 115857 | 116299 | 116300 | 116301 | 116302 | 116303 | 116304 | 116305 | 116355 | 116356 | 116357 | 116358 | 116359 | 116360 | 116361 | 116511 | 126182 | 126183 | 126184 | 126185 | 126186 | 126187 | 126188 | 126189 | 127231 | 127232 | 127235 | 127236 | 127239 | 127240 | 127241 | 127242 | 127243 | 127244