Bugzilla – Attachment 126226 Details for
Bug 29196
Follow-up to Bug 27068 - Remove unnecessary check
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29196: Follow-up to Bug 27068 - Remove unnecessary check
Bug-29196-Follow-up-to-Bug-27068---Remove-unnecess.patch (text/plain), 1.31 KB, created by
Kyle M Hall (khall)
on 2021-10-13 16:24:39 UTC
(
hide
)
Description:
Bug 29196: Follow-up to Bug 27068 - Remove unnecessary check
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2021-10-13 16:24:39 UTC
Size:
1.31 KB
patch
obsolete
>From b2d052129d19a9b386701f155968cf936efb5413 Mon Sep 17 00:00:00 2001 >From: Kyle Hall <kyle@bywatersolutions.com> >Date: Wed, 13 Oct 2021 12:20:33 -0400 >Subject: [PATCH] Bug 29196: Follow-up to Bug 27068 - Remove unnecessary check > >The introduction of _checkHoldPolicy has made this check superfluous. > >Test Plan: >1) Apply this patch >2) prove t/db_dependent/HoldsQueue.t >--- > C4/HoldsQueue.pm | 4 ---- > 1 file changed, 4 deletions(-) > >diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm >index b4d2b026f28..e22d380747d 100644 >--- a/C4/HoldsQueue.pm >+++ b/C4/HoldsQueue.pm >@@ -615,10 +615,6 @@ sub MapItemsToHoldRequests { > next unless _checkHoldPolicy($item, $request); > next unless $items_by_itemnumber{ $item->{itemnumber} }->{_object}->can_be_transferred( { to => $libraries->{ $request->{branchcode} } } ); > >- # Don't fill item level holds that contravene the hold pickup policy at this time >- next unless $item->{hold_fulfillment_policy} eq 'any' >- || $request->{branchcode} eq $item->{ $item->{hold_fulfillment_policy} }; >- > # If hold itemtype is set, item's itemtype must match > next unless ( !$request->{itemtype} > || $item->{itype} eq $request->{itemtype} ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29196
:
125963
|
126226
|
126788
|
140832
|
141131
|
141155