Attachment 126278 Details for Bug 29225 – Bug 29225: Don't hide subgroup filter on pag load

[patch] Bug 29225: Don't hide subgroup filter on pag load

Bug-29225-Dont-hide-subgroup-filter-on-pag-load.patch (text/plain), 1.61 KB, created by Kyle M Hall (khall) on 2021-10-14 13:29:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-10-14 13:29:40 UTC

Size: 1.61 KB

patch

obsolete

>From 1b735c7f0b285644b0b13b0e8cab4bb6e0455156 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 14 Oct 2021 12:28:30 +0000
>Subject: [PATCH] Bug 29225: Don't hide subgroup filter on pag load
>
>When we auto select the last used tab, we hit code that hides the Subgroup
>dropdown
>
>Clicking to other tabs shows the dropdown again
>
>There is code on the tab selection to hide subgroups on the 'All' tab,
>the other line seems superfluous
>
>To test:
>1 - Create a report and assign a group and subgroup, creating if necessary
>2 - Browse to "Reports->Use saved"
>3 - Click on the tab for the report you just created, see the subgroups dropdown
>4 - Reload the page, Subgroups dropdown disappears
>5 - Apply patch
>6 - Relaod the page
>7 - It's back!
>8 - Confirm dropdown filters as expected
>
>Signed-off-by: Donna <donna@bywatersolutions.com>
>---
> .../prog/en/modules/reports/guided_reports_start.tt              | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 1a4c2d9a3d..d61453eb05 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -1752,7 +1752,6 @@
>                 if( activeTab ){
>                     $("#tabs").tabs("option","active", activeTab );
>                 }
>-                $("#subgroup_filter_block").hide();
> 
>                 $("#subgroup_filter").change(function() {
>                     var selected = $(this).find('option:selected');
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29225: 126276 | 126278 | 126621