Bugzilla – Attachment 126308 Details for
Bug 27173
Add plugin hooks for authority record changes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27173: Add tests
Bug-27173-Add-tests.patch (text/plain), 3.71 KB, created by
Martin Renvoize (ashimema)
on 2021-10-15 07:32:39 UTC
(
hide
)
Description:
Bug 27173: Add tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-10-15 07:32:39 UTC
Size:
3.71 KB
patch
obsolete
>From 0acc5697f165f46ea58d7c89d6cd4447ba7e20aa Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 28 Sep 2021 13:39:58 +0000 >Subject: [PATCH] Bug 27173: Add tests > >Test plan: >Run t/db_dependent/Koha/Plugins/authority_hooks.t > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Koha/Plugins/authority_hooks.t | 70 +++++++++++++++++++ > t/lib/Koha/Plugin/Test.pm | 7 ++ > 2 files changed, 77 insertions(+) > create mode 100755 t/db_dependent/Koha/Plugins/authority_hooks.t > >diff --git a/t/db_dependent/Koha/Plugins/authority_hooks.t b/t/db_dependent/Koha/Plugins/authority_hooks.t >new file mode 100755 >index 0000000000..75faee5ddc >--- /dev/null >+++ b/t/db_dependent/Koha/Plugins/authority_hooks.t >@@ -0,0 +1,70 @@ >+#!/usr/bin/perl >+ >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it under the >+# terms of the GNU General Public License as published by the Free Software >+# Foundation; either version 3 of the License, or (at your option) any later >+# version. >+# >+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License along >+# with Koha; if not, see <http://www.gnu.org/licenses>. >+ >+use Modern::Perl; >+ >+use MARC::Record; >+use Test::More tests => 4; >+use Test::Warn; >+ >+use File::Basename; >+ >+use C4::AuthoritiesMarc (); >+use Koha::Database; >+ >+use t::lib::Mocks; >+use t::lib::TestBuilder; >+ >+BEGIN { >+ # Mock pluginsdir before loading Plugins module >+ my $path = dirname(__FILE__) . '/../../../lib'; >+ t::lib::Mocks::mock_config( 'pluginsdir', $path ); >+ >+ use_ok('Koha::Plugins'); >+ use_ok('Koha::Plugins::Handler'); >+ use_ok('Koha::Plugin::Test'); >+} >+ >+my $schema = Koha::Database->new->schema; >+my $builder = t::lib::TestBuilder->new; >+ >+t::lib::Mocks::mock_config( 'enable_plugins', 1 ); >+ >+subtest 'after_authority_action hook' => sub { >+ plan tests => 3; >+ >+ $schema->storage->txn_begin; >+ >+ my $plugins = Koha::Plugins->new; >+ $plugins->InstallPlugins; >+ my $plugin = Koha::Plugin::Test->new->enable; >+ my $id; >+ >+ warning_like { ( $id ) = C4::AuthoritiesMarc::AddAuthority( MARC::Record->new, undef, 'PERSO_NAME' ); } >+ qr/after_authority_action called with action: create, id: \d+/, >+ 'AddAuthority calls the hook with action=create, id passed'; >+ >+ warning_like { C4::AuthoritiesMarc::ModAuthority( $id, MARC::Record->new, 'PERSO_NAME', { skip_merge => 1 } ); } >+ qr/after_authority_action called with action: modify, id: $id/, >+ 'ModAuthority calls the hook with action=modify, id passed'; >+ >+ warning_like { C4::AuthoritiesMarc::DelAuthority({ authid => $id, skip_merge => 1 }); } >+ qr/after_authority_action called with action: delete, id: $id/, >+ 'DelAuthority calls the hook with action=delete, id passed'; >+ >+ $schema->storage->txn_rollback; >+ Koha::Plugins::Methods->delete; >+}; >diff --git a/t/lib/Koha/Plugin/Test.pm b/t/lib/Koha/Plugin/Test.pm >index af8c35cd34..666825a53d 100644 >--- a/t/lib/Koha/Plugin/Test.pm >+++ b/t/lib/Koha/Plugin/Test.pm >@@ -175,6 +175,13 @@ sub after_item_action { > } > } > >+sub after_authority_action { >+ my ( $self, $params ) = @_; >+ my $action = $params->{action} // q{}; >+ my $id = $params->{authority_id} // 0; >+ Koha::Exceptions::Exception->throw("after_authority_action called with action: $action, id: $id"); >+} >+ > sub after_circ_action { > my ( $self, $params ) = @_; > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27173
:
125409
|
125410
|
125411
|
125412
|
125715
|
125716
|
126307
| 126308