Attachment 126383 Details for Bug 28445 – Bug 28445: Improve robustness of tests

[patch] Bug 28445: Improve robustness of tests

Bug-28445-Improve-robustness-of-tests.patch (text/plain), 1.21 KB, created by Tomás Cohen Arazi (tcohen) on 2021-10-15 18:50:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-10-15 18:50:51 UTC

Size: 1.21 KB

patch

obsolete

>From 613a1a5476a554e2de2e6e4cb30256a161e30fd6 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 6 Oct 2021 15:45:17 +0200
>Subject: [PATCH] Bug 28445: Improve robustness of tests
>
>* Libraries are ordered by name by default but if others have been added
>the test may fail
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> t/db_dependent/Koha/UI/Form/Builder/Item.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/UI/Form/Builder/Item.t b/t/db_dependent/Koha/UI/Form/Builder/Item.t
>index 413d837c8c..386241c637 100755
>--- a/t/db_dependent/Koha/UI/Form/Builder/Item.t
>+++ b/t/db_dependent/Koha/UI/Form/Builder/Item.t
>@@ -96,7 +96,7 @@ subtest 'authorised values' => sub {
>     subtest 'branches' => sub {
>         plan tests => 2;
>         my ( $subfield ) = grep { $_->{kohafield} eq 'items.homebranch' } @$subfields;
>-        my $libraries = Koha::Libraries->search;
>+        my $libraries = Koha::Libraries->search({}, { order_by => 'branchname' });
>         is_deeply(
>             $subfield->{marc_value}->{values},
>             [ $libraries->get_column('branchcode') ]
>-- 
>2.33.1

Actions: View | Diff | Splinter Review

Attachments on bug 28445: 121372 | 123221 | 123222 | 123223 | 123224 | 123225 | 123226 | 123227 | 123228 | 123229 | 123239 | 123240 | 125801 | 125802 | 125803 | 125804 | 125805 | 125808 | 125810 | 125811 | 125812 | 125817 | 125865 | 126046 | 126047 | 126136 | 126137 | 126138 | 126139 | 126140 | 126141 | 126142 | 126217 | 126218 | 126219 | 126223 | 126328 | 126329 | 126330 | 126331 | 126332 | 126333 | 126334 | 126335 | 126336 | 126337 | 126338 | 126339 | 126352 | 126353 | 126354 | 126355 | 126356 | 126357 | 126358 | 126359 | 126360 | 126361 | 126362 | 126363 | 126364 | 126365 | 126366 | 126367 | 126374 | 126375 | 126376 | 126377 | 126378 | 126379 | 126380 | 126381 | 126382 | 126383 | 126384 | 126385 | 126386 | 126387 | 126388 | 126389 | 127033 | 127037 | 127038 | 127039 | 128007 | 128008 | 128009