Bugzilla – Attachment 126478 Details for
Bug 29221
On returns.tt modal displays wrong message when lost items are returned
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29221: Correctly display refund info
Bug-29221-Correctly-display-refund-info.patch (text/plain), 1.58 KB, created by
Martin Renvoize (ashimema)
on 2021-10-19 10:07:44 UTC
(
hide
)
Description:
Bug 29221: Correctly display refund info
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-10-19 10:07:44 UTC
Size:
1.58 KB
patch
obsolete
>From 0e4410c18adaf898e5982e8d6db9bc8b811be3ed Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 19 Oct 2021 11:39:48 +0200 >Subject: [PATCH] Bug 29221: Correctly display refund info > >2132 $messages->{'LostItemFeeRefunded'} = $updated_item->{_refunded}; > >But, in returns.pl: >495 elsif ( $code eq 'LostItemFeeRefunded' ) { >496 $template->param( LostItemFeeRefunded => 1 ); >497 } > >1. Set BlockReturnOfLostItems to 'don't block' >2. Make sure your 'Default lost item fee refund on return policy' circ rule is set to 'Leave lost item charge' >3. Check something out and then mark it as lost. >4. Check the item in >=> No message to tell there was a refund > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Circulation.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index a43c104d53..d8a1cf1a65 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2129,8 +2129,8 @@ sub AddReturn { > if ($item_was_lost) { > $messages->{'WasLost'} = 1; > unless ( C4::Context->preference("BlockReturnOfLostItems") ) { >- $messages->{'LostItemFeeRefunded'} = $updated_item->{_refunded}; >- $messages->{'LostItemFeeRestored'} = $updated_item->{_restored}; >+ $messages->{'LostItemFeeRefunded'} = 1 if $updated_item->{_refunded}; >+ $messages->{'LostItemFeeRestored'} = 1 if $updated_item->{_restored}; > > if ( $updated_item->{_charge} ) { > $issue //= Koha::Old::Checkouts->search( >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29221
:
126476
|
126478
|
126557