Attachment 126530 Details for Bug 29279 – Bug 29279: Don't sort holds ratio numeric columns as 'natural'

[patch] Bug 29279: Don't sort holds ratio numeric columns as 'natural'

Bug-29279-Dont-sort-holds-ratio-numeric-columns-as.patch (text/plain), 1.52 KB, created by Andrew Fuerste-Henry on 2021-10-19 17:21:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Fuerste-Henry

Created: 2021-10-19 17:21:44 UTC

Size: 1.52 KB

patch

obsolete

>From 46ef1fcfc82280c02d0082694bfb3b35034ecd9f Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 19 Oct 2021 16:47:50 +0000
>Subject: [PATCH] Bug 29279: Don't sort holds ratio numeric columns as
> 'natural'
>
>TO test:
>1 - Place a variety of holds on some records
>2 - Place more holds on records with low biblionumbers and less on ones with high biblionumbers
>3 - Go to Circulation->Holds ratios
>4 - Set the ration to 1 and load the report
>5 - Sort by the 'Holds ratio' column and note it is incorrect
>6 - Apply patch
>7 - Confirm sort works correctly on first three columns and call numbers column
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
>index 2a11966fa0..36b0844235 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt
>@@ -196,7 +196,7 @@
>             KohaTable("holdst", {
>                 "aaSorting": [ [2,'desc'], [3,'asc'] ],
>                   "aoColumnDefs": [
>-                      { "aTargets": [ 0,1,2,8 ], "sType": "natural" },
>+                      { "aTargets": [ 8 ], "sType": "natural" },
>                       { "aTargets": [ 3 ], "sType": "anti-the" },
>                     ],
>                 "sPaginationType": "full",
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29279: 126529 | 126530 | 126552 | 126644