Attachment 126691 Details for Bug 29306 – Bug 29306: Fix warning on undefined $_ in Holds.t

[patch] Bug 29306: Fix warning on undefined $_ in Holds.t

Bug-29306-Fix-warning-on-undefined--in-Holdst.patch (text/plain), 1.10 KB, created by Marcel de Rooy on 2021-10-22 08:20:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-10-22 08:20:36 UTC

Size: 1.10 KB

patch

obsolete

>From bcacdf1e4119f47cf794b55b0e81cf53d4acd83b Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 22 Oct 2021 08:19:01 +0000
>Subject: [PATCH] Bug 29306: Fix warning on undefined $_ in Holds.t
>Content-Type: text/plain; charset=utf-8
>
>Use of uninitialized value $_ in concatenation (.) or string at t/db_dependent/Holds.t line 1658.
>
>Results from copying line 70.
>
>Test plan:
>Run Holds.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Holds.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t
>index b62bc123bd..69e9b2bc10 100755
>--- a/t/db_dependent/Holds.t
>+++ b/t/db_dependent/Holds.t
>@@ -1626,7 +1626,7 @@ subtest 'ModReserve can only update expirationdate for found holds' => sub {
>     my $borrowernumber = Koha::Patron->new(
>         {
>             firstname    => 'my firstname',
>-            surname      => 'my surname ' . $_,
>+            surname      => 'whatever surname',
>             categorycode => $category->{categorycode},
>             branchcode   => $branch,
>         }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29306: 126691 | 126797