Bugzilla – Attachment 12674 Details for
Bug 8849
Error log generated when not a demo system
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8739 follow-up fixing perlcritic error
Bug-8739-follow-up-fixing-perlcritic-error.patch (text/plain), 1.23 KB, created by
Frédéric Demians
on 2012-10-04 08:43:18 UTC
(
hide
)
Description:
Bug 8739 follow-up fixing perlcritic error
Filename:
MIME Type:
Creator:
Frédéric Demians
Created:
2012-10-04 08:43:18 UTC
Size:
1.23 KB
patch
obsolete
>From 0b736af921f127f45e062bb0a24455621b877833 Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Wed, 3 Oct 2012 18:02:38 +0200 >Subject: [PATCH] Bug 8739 follow-up fixing perlcritic error > >This patch is not related nor introduced by bug 8739, but while qa-ing it, I found those 2 perlcritic violation > >this patch fixes it ! > >I also fixed a tiny indentation problem > >http://bugs.koha-community.org/show_bug.cgi?id=8849 >--- > C4/Accounts.pm | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/C4/Accounts.pm b/C4/Accounts.pm >index f76ae01..8a0212f 100644 >--- a/C4/Accounts.pm >+++ b/C4/Accounts.pm >@@ -243,13 +243,13 @@ borrower number. > > #' > # FIXME - Okay, so what does the above actually _mean_? >-sub getnextacctno ($) { >- my ($borrowernumber) = shift or return undef; >+sub getnextacctno { >+ my ($borrowernumber) = shift or return; > my $sth = C4::Context->dbh->prepare( > "SELECT accountno+1 FROM accountlines >- WHERE (borrowernumber = ?) >- ORDER BY accountno DESC >- LIMIT 1" >+ WHERE (borrowernumber = ?) >+ ORDER BY accountno DESC >+ LIMIT 1" > ); > $sth->execute($borrowernumber); > return ($sth->fetchrow || 1); >-- >1.7.11.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8849
:
12616
|
12674
|
12707
|
12718