Attachment 126803 Details for Bug 29227 – Bug 29227: Patron messaging preferences digest show as editable but are not

[patch] Bug 29227: Patron messaging preferences digest show as editable but are not

Bug-29227-Patron-messaging-preferences-digest-show.patch (text/plain), 1.72 KB, created by Katrin Fischer on 2021-10-24 11:05:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-10-24 11:05:35 UTC

Size: 1.72 KB

patch

obsolete

>From cdbfd443dd03229f6a7bee78f2885323cc45bda6 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 14 Oct 2021 12:03:31 +0000
>Subject: [PATCH] Bug 29227: Patron messaging preferences digest show as
> editable but are not
>
>On moremember.pl we load the messaging preferences for display only, we do
>not need to load the JS for editing the preferences
>
>To test:
>0 - Enable EnhancedMessagingPreferences
>1 - Load the detais tab for a member
>2 - Note the digest column in messaging preferences is clickable
>3 - Apply patch
>4 - Reload, it is not clickable
>5 - Confirm editing the patron (or their messaging prefs) works as expected
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index 55c4d8e740..91bc3db21f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -888,12 +888,12 @@
>     [% Asset.js("js/holds.js") | $raw %]
>     [% INCLUDE 'str/members-menu.inc' %]
>     [% Asset.js("js/members-menu.js") | $raw %]
>-    [% Asset.js("js/messaging-preference-form.js") | $raw %]
>     <script>
> 
>         columns_settings_issues_table = [% TablesSettings.GetColumns( 'members', 'moremember', 'issues-table', 'json' ) | $raw %]
> 
>         $(document).ready(function() {
>+            $("#info_digests").tooltip();
> 
>             if ( $('#clubs-tab').length ) {
>                 $('#clubs-tab-link').on('click', function() {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 29227: 126275 | 126310 | 126803