Attachment 126842 Details for Bug 29318 – Bug 29318: Remove permission check from overdrive search page

[patch] Bug 29318: Remove permission check from overdrive search page

Bug-29318-Remove-permission-check-from-overdrive-s.patch (text/plain), 1.67 KB, created by Owen Leonard on 2021-10-25 19:05:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2021-10-25 19:05:53 UTC

Size: 1.67 KB

patch

obsolete

>From c05ecf44a934efc67082ec0862909a7923031d2e Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 25 Oct 2021 18:47:22 +0000
>Subject: [PATCH] Bug 29318: Remove permission check from overdrive search page
>
>This removes the 'edit_borrowers' permission from OverDrive search
>
>To test:
>1 - Enable OverDrive via koha system preferences
>2 - Sign in to opac with a user with no permissions
>3 - Perform a search that will return OD results, 'love' works
>4 - Click thje "Found XX results in the library's OverDrive collection"
>5 - Note you are logged out of Koha
>6 - Apply patch
>7 - Repeat
>8 - Success
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> opac/opac-overdrive-search.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/opac/opac-overdrive-search.pl b/opac/opac-overdrive-search.pl
>index 575596d8a0..0fbb7b22d3 100755
>--- a/opac/opac-overdrive-search.pl
>+++ b/opac/opac-overdrive-search.pl
>@@ -22,6 +22,7 @@ use Modern::Perl;
> use CGI qw ( -utf8 );
> 
> use C4::Auth qw( get_template_and_user );
>+use C4::Context;
> use C4::Output qw( output_html_with_http_headers );
> 
> my $cgi = CGI->new;
>@@ -31,8 +32,7 @@ my ($template, $loggedinuser, $cookie)
> = get_template_and_user({template_name => "opac-overdrive-search.tt",
>                                 query => $cgi,
>                                 type => "opac",
>-                                authnotrequired => 1,
>-                                flagsrequired => {borrowers => 'edit_borrowers'},
>+                                authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),
>                                 });
> 
> $template->{'VARS'}->{'q'} = $cgi->param('q');
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29318: 126840 | 126841 | 126842 | 126843 | 126849 | 126850