Attachment 126975 Details for Bug 29075 – Bug 29075: 'OPAC info' removed in branches.pl

[patch] Bug 29075: 'OPAC info' removed in branches.pl

Bug-29075-OPAC-info-removed-in-branchespl.patch (text/plain), 2.62 KB, created by Jérémy Breuillard on 2021-10-27 11:52:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jérémy Breuillard

Created: 2021-10-27 11:52:00 UTC

Size: 2.62 KB

patch

obsolete

>From 6132aa7e57b52f210f6c80942e5f2b308866c301 Mon Sep 17 00:00:00 2001
>From: jeremy breuillard <jeremy.breuillard@biblibre.com>
>Date: Wed, 27 Oct 2021 10:24:36 +0000
>Subject: [PATCH] Bug 29075: 'OPAC info' removed in branches.pl
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>In Administration âº Libraries, we see content of OPAC info as escaped
>HTML.
>This content may be long and seeing HTML tags is strange.
>
>We should not show it in this table.
>Or maybe create a modal preview of it (not escaped HTML).
>
>To test :
>1) Home > Administration > Libraries
>2) In 'Address' column notice the 'OPAC info' field (if this one is filled) with visible HTML tags
>3) Apply patch
>4) Repeat 1) and 'OPAC info' field should be gone here and in
>opac-library.pl
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>index 6ce5842..c07e0a8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>@@ -235,7 +235,6 @@ Libraries &rsaquo; Administration &rsaquo; Koha
>                     </select>
>                 </li>
>                 <li><label for="branchurl">URL: </label><input type="text" name="branchurl" id="branchurl"  size="80" value="[% library.branchurl | html %]" class="url" /></li>
>-                <li><label for="opac_info">OPAC info: </label><textarea name="opac_info" id="opac_info">[% library.opac_info | $raw %]</textarea></li>
>                 <li>
>                     <label for="branchip">IP: </label>
>                     <input type="text" name="branchip" id="branchip"  size="15" maxlength="15" value="[% library.branchip | html %]" />
>@@ -385,7 +384,6 @@ Libraries &rsaquo; Administration &rsaquo; Koha
>                             if ( row.fax != null ) library_info.push(_("Fax: ") + row.fax.escapeHtml());
>                             if ( row.email != null ) library_info.push('<a href="mailto:'+encodeURIComponent(row.email)+'">'+row.email.escapeHtml()+'</a>');
>                             if ( row.url != null ) library_info.push('<a href="'+encodeURIComponent(row.url)+'">'+row.url.escapeHtml()+'</a>');
>-                            if ( row.opac_info != null ) library_info.push(_("OPAC Info") + ': <div>'+row.opac_info.escapeHtml()+'</div>');
>                             if ( row.notes != null ) library_info.push(_("Notes")+': '+row.notes.escapeHtml());
>                             return library_info.join('<br/>');
>                         },
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 29075: 126975 | 126987 | 126994 | 126996 | 127072 | 127127