Attachment 127039 Details for Bug 28445 – Bug 28445: Fix LostItem call and display errors

[patch] Bug 28445: Fix LostItem call and display errors

Bug-28445-Fix-LostItem-call-and-display-errors.patch (text/plain), 1.38 KB, created by Jonathan Druart on 2021-10-28 10:06:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-10-28 10:06:15 UTC

Size: 1.38 KB

patch

obsolete

>From 8103370a4b2622ef2026ac5f586fa372f34d09c3 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 28 Oct 2021 12:03:58 +0200
>Subject: [PATCH] Bug 28445: Fix LostItem call and display errors
>
>Never a try without a catch, ever!
>---
> Koha/Items.pm | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Items.pm b/Koha/Items.pm
>index d0c67e1db03..0730935a0b9 100644
>--- a/Koha/Items.pm
>+++ b/Koha/Items.pm
>@@ -24,6 +24,7 @@ use Try::Tiny;
> 
> use C4::Context;
> use C4::Biblio qw( GetMarcStructure GetMarcFromKohaField );
>+use C4::Circulation;
> 
> use Koha::Database;
> use Koha::SearchEngine::Indexer;
>@@ -328,7 +329,7 @@ sub batch_update {
>                 my $itemlost_pre = $item->itemlost;
>                 $item->set($new_values)->store({skip_record_index => 1});
> 
>-                LostItem(
>+                C4::Circulation::LostItem(
>                     $item->itemnumber, 'batchmod', undef,
>                     { skip_record_index => 1 }
>                 ) if $item->itemlost
>@@ -337,7 +338,10 @@ sub batch_update {
> 
>             push @modified_itemnumbers, $item->itemnumber if $modified || $modified_holds_priority;
>             $modified_fields += $modified + $modified_holds_priority;
>-        })};
>+        })}
>+        catch {
>+            warn $_
>+        };
> 
>         if ( $callback ) {
>             $callback->(++$i);
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 28445: 121372 | 123221 | 123222 | 123223 | 123224 | 123225 | 123226 | 123227 | 123228 | 123229 | 123239 | 123240 | 125801 | 125802 | 125803 | 125804 | 125805 | 125808 | 125810 | 125811 | 125812 | 125817 | 125865 | 126046 | 126047 | 126136 | 126137 | 126138 | 126139 | 126140 | 126141 | 126142 | 126217 | 126218 | 126219 | 126223 | 126328 | 126329 | 126330 | 126331 | 126332 | 126333 | 126334 | 126335 | 126336 | 126337 | 126338 | 126339 | 126352 | 126353 | 126354 | 126355 | 126356 | 126357 | 126358 | 126359 | 126360 | 126361 | 126362 | 126363 | 126364 | 126365 | 126366 | 126367 | 126374 | 126375 | 126376 | 126377 | 126378 | 126379 | 126380 | 126381 | 126382 | 126383 | 126384 | 126385 | 126386 | 126387 | 126388 | 126389 | 127033 | 127037 | 127038 | 127039 | 128007 | 128008 | 128009