Bugzilla – Attachment 127110 Details for
Bug 28263
AUTO_RENEWALS message for 'too_many' is wrong
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28263: (QA follow-up) Use new atomicupdate code style
Bug-28263-QA-follow-up-Use-new-atomicupdate-code-s.patch (text/plain), 2.35 KB, created by
Joonas Kylmälä
on 2021-10-30 20:59:04 UTC
(
hide
)
Description:
Bug 28263: (QA follow-up) Use new atomicupdate code style
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-10-30 20:59:04 UTC
Size:
2.35 KB
patch
obsolete
>From ca02b11a150aed73d0f39420d76ce55c8073e45a Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi> >Date: Sat, 30 Oct 2021 20:19:39 +0000 >Subject: [PATCH] Bug 28263: (QA follow-up) Use new atomicupdate code style >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> >--- > .../bug_28263-fix_auto_renewal_message.pl | 15 +++++++++++++++ > .../bug_28263_fix_auto_renewal_message.perl | 10 ---------- > 2 files changed, 15 insertions(+), 10 deletions(-) > create mode 100755 installer/data/mysql/atomicupdate/bug_28263-fix_auto_renewal_message.pl > delete mode 100644 installer/data/mysql/atomicupdate/bug_28263_fix_auto_renewal_message.perl > >diff --git a/installer/data/mysql/atomicupdate/bug_28263-fix_auto_renewal_message.pl b/installer/data/mysql/atomicupdate/bug_28263-fix_auto_renewal_message.pl >new file mode 100755 >index 0000000000..d7e0c706de >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_28263-fix_auto_renewal_message.pl >@@ -0,0 +1,15 @@ >+use Modern::Perl; >+ >+return { >+ bug_number => "28263", >+ description => "Update AUTO_RENEWAL too_many message", >+ up => sub { >+ my ($args) = @_; >+ my ($dbh) = @$args{qw(dbh)}; >+ $dbh->do(q{ >+ UPDATE letter SET >+ content = REPLACE(content, "You have reached the maximum number of checkouts possible." , "You have reached the maximum number of renewals possible.") >+ WHERE ( code = 'AUTO_RENEWALS' OR code = 'AUTO_RENEWALS_DGST' ); >+ }); >+ }, >+} >diff --git a/installer/data/mysql/atomicupdate/bug_28263_fix_auto_renewal_message.perl b/installer/data/mysql/atomicupdate/bug_28263_fix_auto_renewal_message.perl >deleted file mode 100644 >index cbfa8e846b..0000000000 >--- a/installer/data/mysql/atomicupdate/bug_28263_fix_auto_renewal_message.perl >+++ /dev/null >@@ -1,10 +0,0 @@ >-$DBversion = 'XXX'; # will be replaced by the RM >-if( CheckVersion( $DBversion ) ) { >- $dbh->do(q{ >- UPDATE letter SET >- content = REPLACE(content, "You have reached the maximum number of checkouts possible." , "You have reached the maximum number of renewals possible.") >- WHERE ( code = 'AUTO_RENEWALS' OR code = 'AUTO_RENEWALS_DGST' ); >- }); >- >- NewVersion( $DBversion, 28263, "Update AUTO_RENEWAL too_many message"); >-} >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28263
:
120315
|
122495
|
126787
|
127108
| 127110