Bugzilla – Attachment 127119 Details for
Bug 29328
Add missing list parameter to reports parameter menu
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29328: Add missing list parameter to reports parameter menu
Bug-29328-Add-missing-list-parameter-to-reports-pa.patch (text/plain), 2.75 KB, created by
Katrin Fischer
on 2021-10-31 00:31:12 UTC
(
hide
)
Description:
Bug 29328: Add missing list parameter to reports parameter menu
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2021-10-31 00:31:12 UTC
Size:
2.75 KB
patch
obsolete
>From 84abc5873105c0f79da298974973fc15684ff270 Mon Sep 17 00:00:00 2001 >From: Owen <oleonard@myacpl.org> >Date: Thu, 28 Oct 2021 15:45:21 +0000 >Subject: [PATCH] Bug 29328: Add missing list parameter to reports parameter > menu > >This patch adds an option to insert "list" as a runtime parameter in SQL >reports (As added by Bug 27380). > >To test, apply the patch and go to Reports -> Create from SQL. > >- Click the "Insert runtime parameter" button and select > "List." >- Customize the parameter label if you wish and click "Insert > parameter." >- The parameter should be inserted like this: > > <<List of values|list>> > >- Use it to create a valid SQL report, for example: > > SELECT * FROM borrowers WHERE categorycode IN <<List of values|list>> > LIMIT 10 > >- Confirm that upon running the report you are shown a textarea. Enter > two or more values in the textarea, each on a separate line. >- Confirm that the report runs correctly. The SQL above would show you > this when you click "Show SQL code": > > SELECT * FROM borrowers WHERE categorycode IN ('A','S') LIMIT 10 > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index e766923601..83a6ec3efb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -1550,6 +1550,11 @@ > $("#paramLabel").val( _("Patron category") ); > $("#param_category").val("categorycode"); > break; >+ case "insertList": >+ modalTitle.text( _("Insert list parameter") ); >+ $("#paramLabel").val( _("List of values") ); >+ $("#param_category").val("list"); >+ break; > case "insertText": > modalTitle.text( _("Insert text parameter") ); > $("#paramLabel").val( _("Text") ); >@@ -2280,6 +2285,7 @@ > <li><a href="#" class="insertParam" id="insertDate">Date</a></li> > <li><a href="#" class="insertParam" id="insertItemtypes">Item types</a></li> > <li><a href="#" class="insertParam" id="insertBranches">Libraries</a></li> >+ <li><a href="#" class="insertParam" id="insertList">List</a></li> > <li><a href="#" class="insertParam" id="insertCategorycode">Patron categories</a></li> > <li><a href="#" class="insertParam" id="insertText">Text field</a></li> > </ul> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29328
:
127065
|
127068
| 127119