Bugzilla – Attachment 127135 Details for
Bug 29283
Cannot delete basket with cancelled order for deleted biblio
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29283: (QA follow-up) Remove code duplication
Bug-29283-QA-follow-up-Remove-code-duplication.patch (text/plain), 1020 bytes, created by
Joonas Kylmälä
on 2021-10-31 12:26:13 UTC
(
hide
)
Description:
Bug 29283: (QA follow-up) Remove code duplication
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-10-31 12:26:13 UTC
Size:
1020 bytes
patch
obsolete
>From 1bd5c2caddd63223904ed5b4ed899a6d3e2fb7c7 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi> >Date: Sun, 31 Oct 2021 12:22:06 +0000 >Subject: [PATCH] Bug 29283: (QA follow-up) Remove code duplication >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >We have already a search filter for active orders. > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> >--- > acqui/basket.pl | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/acqui/basket.pl b/acqui/basket.pl >index 3694348a5a..1a2b2758a0 100755 >--- a/acqui/basket.pl >+++ b/acqui/basket.pl >@@ -127,9 +127,7 @@ if ( $op eq 'delete_confirm' ) { > my $delbiblio = $query->param('delbiblio'); > my $basket_obj = Koha::Acquisition::Baskets->find($basketno); > >- my $orders = $basket_obj->orders->search({ >- datecancellationprinted => undef >- }); >+ my $orders = $basket_obj->orders->filter_by_current; > > my @cannotdelbiblios; > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29283
:
126585
|
126589
|
127134
| 127135