Bugzilla – Attachment 127151 Details for
Bug 24406
Add a span to patron category category type codes in patron search result lists
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24406: Wrap patron category type code in a span on patron search results
Bug-24406-Wrap-patron-category-type-code-in-a-span.patch (text/plain), 4.69 KB, created by
Martin Renvoize (ashimema)
on 2021-11-01 10:18:29 UTC
(
hide
)
Description:
Bug 24406: Wrap patron category type code in a span on patron search results
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-11-01 10:18:29 UTC
Size:
4.69 KB
patch
obsolete
>From 69f54d5641cb4fb05265c852336af65d4843e6df Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 22 Aug 2021 14:20:55 +0000 >Subject: [PATCH] Bug 24406: Wrap patron category type code in a span on patron > search results > >The patron category type code (A, C, O, ...) is currently displayed in the >patron module search and the patron card creator and acquisition patron searches. > >This information is not useful for most users, as these are internal codes >that cannot be easily "decoded". And while you might be able to guess A as >Adult in English, it doesn't translate to other languages. > >This patch wraps a span around the patron category type code shown >in () after the patron category. > >To test: >- Verify for each of the following three searches, that the patron category code > displays in the search results, but is wrapped in a span with the class > patron_category_type >- Tools > Patron card creator > - New > New card batch > Add patrons > - Search for patrons >- Patrons > - Search for patrons >- Acquisitions > - Add a budget > - Add a fund for the budget > - Search for a user or owner to add > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../prog/en/modules/acqui/tables/members_results.tt | 2 +- > .../prog/en/modules/members/tables/members_results.tt | 2 +- > .../prog/en/modules/patroncards/tables/members_results.tt | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt >index b90a8d795d..50cc702350 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt >@@ -13,7 +13,7 @@ > "dt_branch": > "[% data.branchname | html %]", > "dt_category": >- "[% data.category_description | html %] ([% data.category_type | html %])", >+ "[% data.category_description | html %] <span class=\"patron_category_type\">([% data.category_type | html %])</span>", > "dt_action": > [%- IF selection_type == 'select' -%] > "<a class=\"btn btn-default btn-xs select_user\" href=\"#\" data-borrowernumber=\"[% data.borrowernumber | html %]\" data-borrowerdata=\"[% To.json(data) | html %]\">Select</a><input type=\"hidden\" id=\"borrower_data[% data.borrowernumber | html %]\" name=\"borrower_data[% data.borrowernumber | html %]\" value=\"[% To.json(data) | html %]\" />" >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt >index 2472127321..6846cdaefd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt >@@ -22,7 +22,7 @@ > "dt_dateofbirth": > "[% INCLUDE 'patron-age.inc' patron = data %]", > "dt_category": >- "[% data.category_description | html | $To %] ([% data.category_type | html | $To %])", >+ "[% data.category_description | html | $To %] <span class=\"patron_category_type\">([% data.category_type | html | $To %])</span>", > "dt_branch": > "[% data.branchname | html | $To %]", > "dt_dateexpiry": >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/tables/members_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/tables/members_results.tt >index f4af6752af..9660e3e56e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/tables/members_results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/tables/members_results.tt >@@ -11,7 +11,7 @@ > "dt_name": > "<a href=\"#\" class=\"patron_preview\" data-borrowernumber=\"[% data.borrowernumber | html %]\" style='white-space:nowrap'>[% INCLUDE 'patron-title.inc' borrowernumber = data.borrowernumber category_type = data.category_type firstname = To.json(data.firstname) surname = To.json(data.surname) othernames = To.json(data.othernames) cardnumber = data.cardnumber invert_name = 1%]</a>", > "dt_category": >- "[% data.category_description | html %] ([% data.category_type | html %])", >+ "[% data.category_description | html %] <span class=\"patron_category_type\">([% data.category_type | html %])</span>", > "dt_branch": > "[% data.branchname | html %]", > "dt_dateexpiry": >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24406
:
124080
|
125989
| 127151