Attachment 127198 Details for Bug 29015 – Bug 29015: (QA follow-up) Change collection code to be just collection

[patch] Bug 29015: (QA follow-up) Change collection code to be just collection

Bug-29015-QA-follow-up-Change-collection-code-to-b.patch (text/plain), 2.96 KB, created by Katrin Fischer on 2021-11-01 21:05:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-11-01 21:05:05 UTC

Size: 2.96 KB

patch

obsolete

>From 6b8a1301be12cb23e5149f485e415b4a1d56162d Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Wed, 27 Oct 2021 14:09:52 +0000
>Subject: [PATCH] Bug 29015: (QA follow-up) Change collection code to be just
> collection
>
>We did some clean-up in that area a little while ago, agreeing that
>as we acutally display the descriptions, the label should be just
>"collection".
>
>This patch also removes some ():
>
>Before:
>4 items found for Centerville and item type:(Books) and collection: (Reference) and shelving location: (General Stacks)
>
>Now:
>4 items found for Centerville and item type: Books and collection: Reference and shelving location: General Stacks
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>index 537fd747d6..b3c73577b2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>@@ -65,9 +65,9 @@
>     [% IF ( total ) %]
>         <div class="results">[% total | html %] items found for
>             [% IF ( branchlimit ) %][% Branches.GetName( branchlimit ) | html %][% ELSE %]All libraries[% END %]
>-            [% IF ( itemtypeslimit ) %] and item type:([% ItemTypes.GetDescription( itemtypeslimit ) | html %])[% END %]
>-            [% IF ( ccodeslimit ) %] and collection code:([% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode' authorised_value = ccodeslimit ) | html %])[% END %]
>-            [% IF ( locationslimit ) %] and shelving location:([% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location' authorised_value = locationslimit ) | html %])[% END %]
>+            [% IF ( itemtypeslimit ) %] and item type: [% ItemTypes.GetDescription( itemtypeslimit ) | html %][% END %]
>+            [% IF ( ccodeslimit ) %] and collection: [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode' authorised_value = ccodeslimit ) | html %][% END %]
>+            [% IF ( locationslimit ) %] and shelving location: [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location' authorised_value = locationslimit ) | html %][% END %]
>         </div>
>     [% ELSE %]
>         <div class="dialog message">No items found.</div>
>@@ -249,7 +249,7 @@
>                     </select>
>                 </li>
>                 <li>
>-                    <label for="ccodeslimit">Collection code: </label>
>+                    <label for="ccodeslimit">Collection: </label>
>                     <select name="ccodeslimit" id="ccodeslimit">
>                         <option value="">All</option>
>                         [% PROCESS options_for_authorised_values authorised_values => AuthorisedValues.GetAuthValueDropbox( 'CCODE' ), selected_av => ccodeslimit %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 29015: 124871 | 124881 | 124883 | 124903 | 124907 | 124908 | 124909 | 124910 | 124915 | 124916 | 124917 | 124918 | 125419 | 125420 | 125421 | 125422 | 125423 | 127191 | 127192 | 127193 | 127194 | 127195 | 127196 | 127197 | 127198 | 127261