Bugzilla – Attachment 127209 Details for
Bug 28782
Get rid of custom query param list creation for request.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28782: (follow-up) Pass real array to query_form()
Bug-28782-follow-up-Pass-real-array-to-queryform.patch (text/plain), 1.70 KB, created by
Martin Renvoize (ashimema)
on 2021-11-02 11:00:13 UTC
(
hide
)
Description:
Bug 28782: (follow-up) Pass real array to query_form()
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-11-02 11:00:13 UTC
Size:
1.70 KB
patch
obsolete
>From 62fec8c5d69c2908c54fe441fbd136669ed31bc8 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi> >Date: Sat, 30 Oct 2021 21:49:10 +0000 >Subject: [PATCH] Bug 28782: (follow-up) Pass real array to query_form() >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >It excepts to receive a real array and not a list, in order to be able >to generate the query parameters. > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > reserve/modrequest.pl | 2 +- > reserve/placerequest.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/reserve/modrequest.pl b/reserve/modrequest.pl >index 6690d0bbaf..eb677995bf 100755 >--- a/reserve/modrequest.pl >+++ b/reserve/modrequest.pl >@@ -96,6 +96,6 @@ if ( $from eq 'borrower'){ > print $query->redirect("/cgi-bin/koha/circ/circulation.pl?borrowernumber=$borrower[0]"); > } else { > my $url = URI->new("/cgi-bin/koha/reserve/request.pl"); >- $url->query_form( biblionumber => @biblionumber); >+ $url->query_form( biblionumber => [@biblionumber]); > print $query->redirect($url); > } >diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl >index b5fdf4c4d7..a9620c954b 100755 >--- a/reserve/placerequest.pl >+++ b/reserve/placerequest.pl >@@ -166,7 +166,7 @@ if ( $type eq 'str8' && $borrower ) { > push @biblionumbers, @bad_bibs; > } > my $redirect_url = URI->new("request.pl"); >- $redirect_url->query_form( biblionumber => @biblionumbers); >+ $redirect_url->query_form( biblionumber => [@biblionumbers]); > print $input->redirect($redirect_url); > } > elsif ( $borrowernumber eq '' ) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28782
:
123286
|
123287
|
123313
|
124510
|
124521
|
127112
|
127208
|
127209
|
129939
|
129940
|
129941
|
129942
|
130663
|
130664
|
130868
|
130869
|
130870
|
130871
|
130872
|
130873
|
130894
|
130895
|
130938
|
130939
|
130940
|
130941
|
130942
|
130943
|
131349
|
131350
|
131351
|
131352
|
131353
|
131354