Attachment 127212 Details for Bug 29389 – Bug 29389: Add holding branch to the holds queue report

[patch] Bug 29389: Add holding branch to the holds queue report

Bug-29389-Add-holding-branch-to-the-holds-queue-re.patch (text/plain), 2.60 KB, created by Nick Clemens (kidclamp) on 2021-11-02 12:01:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-11-02 12:01:14 UTC

Size: 2.60 KB

patch

obsolete

>From fdbc443c3f01e41267f3f37ff73985616ab7c7ad Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 2 Nov 2021 11:57:21 +0000
>Subject: [PATCH] Bug 29389: Add holding branch to the holds queue report
>
>This patch adds the holding branch to the hold queue report.
>It is added as hidden by default, when running per branch it is not needed
>
>To test:
>1 - Place some holds in your system
>2 - perl misc/cronjobs/holds/build_holdsqueue.pl
>3 - View the holds queue
>4 - Note there is no holding branch column
>5 - Apply patch
>6 - Reload
>7 - Note the column is not there
>8 - Click column setting gear
>9 - Check the column and confirm it appears
>10 - Confirmthe filter works
>---
> admin/columns_settings.yml                                 | 3 +++
> .../intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt  | 7 +++++++
> 2 files changed, 10 insertions(+)
>
>diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml
>index 0feca3f3bb..074f0097bd 100644
>--- a/admin/columns_settings.yml
>+++ b/admin/columns_settings.yml
>@@ -1175,6 +1175,9 @@ modules:
>     view_holdsqueue:
>       holds-table:
>         columns:
>+            -
>+              columnname: holdingbranch
>+              is_hidden: 1
>             -
>               columnname: title
>             -
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>index b3c73577b2..9230343e06 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>@@ -76,6 +76,7 @@
> <table id="holdst">
> 	<thead>
>     <tr>
>+        <th class="hq-holdingbranch">Holdingbranch</th>
>         <th class="hq-title anti-the">Title</th>
>         <th class="hq-collection">Collection</th>
>         <th class="hq-itemtype">Item type</th>
>@@ -89,6 +90,11 @@
>         <th class="hq-notes">Notes</th>
>     </tr>
>     <tr>
>+        <td class="hq-holdingbranch">
>+            <span class="filter_column filter_text">
>+                <input class="text_filter" type="text" placeholder="Holding branch">
>+            </span>
>+        </td>
>         <td class="hq-title">
>             <span class="filter_column filter_text">
>                 <input class="text_filter" type="text" placeholder="Title">
>@@ -148,6 +154,7 @@
> 	</thead>
>      <tbody>[% FOREACH itemsloo IN itemsloop %]
>         <tr>
>+            <td class="hq-holdingbranch">[% Branches.GetName( itemsloo.holdingbranch ) | html %]</td>
>             <td class="hq-title">
>                 <p>
>                     [% INCLUDE 'biblio-title.inc' biblio=itemsloo link = 1 %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29389: 127212 | 140828 | 140829 | 140835 | 141201