Attachment 127219 Details for Bug 28365 – Bug 28365: Add unit test

[patch] Bug 28365: Add unit test

Bug-28365-Add-unit-test.patch (text/plain), 1.66 KB, created by Martin Renvoize (ashimema) on 2021-11-02 15:22:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-11-02 15:22:28 UTC

Size: 1.66 KB

patch

obsolete

>From 18a75052e9a409868f0319f3d9401e5db1ee700a Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Mon, 17 May 2021 16:15:19 +0200
>Subject: [PATCH] Bug 28365: Add unit test
>
>Run prove t/db_dependent/Search.t
>
>Without fix you get error :
>    #   Failed test 'buildQuery should keep 0 value in query_cgi'
>    #   at t/db_dependent/Search.t line 670.
>    #          got: 'idx=su%2Cphr'
>    #     expected: 'idx=su%2Cphr&q=0'
>
>This patch also adds a test for query_desc in case it is broken in the
>future.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Search.t | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Search.t b/t/db_dependent/Search.t
>index 6d84995b93..6a1abe54a3 100755
>--- a/t/db_dependent/Search.t
>+++ b/t/db_dependent/Search.t
>@@ -641,7 +641,9 @@ ok(MARC::Record::new_from_xml($results_hashref->{biblioserver}->{RECORDS}->[0],'
>     ( $error, $query, $simple_query, $query_cgi,
>     $query_desc, $limit, $limit_cgi, $limit_desc,
>     $query_type ) = buildQuery([], [ 0 ], [ 'su,phr' ], [], [], 0, 'en');
>-    is($query, 'su,phr=(rk=(0)) ', 'buildQuery should keep 0 value');
>+    is($query, 'su,phr=(rk=(0)) ', 'buildQuery should keep 0 value in query');
>+    is($query_cgi, 'idx=su%2Cphr&q=0', 'buildQuery should keep 0 value in query_cgi');
>+    is($query_desc, 'su,phr: 0', 'buildQuery should keep 0 value in query_desc');
> 
>     # Bug 23086
>     ( $error, $query, $simple_query, $query_cgi,
>@@ -899,7 +901,7 @@ sub run_unimarc_search_tests {
> }
> 
> subtest 'MARC21 + DOM' => sub {
>-    plan tests => 88;
>+    plan tests => 90;
>     run_marc21_search_tests();
> };
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28365: 121054 | 121055 | 127219 | 127220