Attachment 127243 Details for Bug 24850 – Bug 24850: Date only are not RFC3339

[patch] Bug 24850: Date only are not RFC3339

Bug-24850-Date-only-are-not-RFC3339.patch (text/plain), 1.21 KB, created by Martin Renvoize (ashimema) on 2021-11-03 11:39:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-11-03 11:39:07 UTC

Size: 1.21 KB

patch

obsolete

>From cf9b65680c8631bba13a71d31523d4f417b7203e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 3 Nov 2021 10:06:35 +0100
>Subject: [PATCH] Bug 24850: Date only are not RFC3339
>
>We removed the fallback on 'Bug 24850: Don't fallback when date_format
>is passed', and the dates passed for date only (YYYY-MM-DD) are not
>RFC3339 formatted but ISO8601.
>We must assume that all dates will be YYYY-MM-DD, without fallback.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Object.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Object.pm b/Koha/Object.pm
>index 5d0f3f720f..54edbd38a0 100644
>--- a/Koha/Object.pm
>+++ b/Koha/Object.pm
>@@ -751,7 +751,7 @@ sub attributes_from_api {
>         elsif ( _date_or_datetime_column_type( $columns_info->{$koha_field_name}->{data_type} ) ) {
>             try {
>                 if ( $columns_info->{$koha_field_name}->{data_type} eq 'date' ) {
>-                    $value = $dtf->format_date(dt_from_string($value, 'rfc3339'))
>+                    $value = $dtf->format_date(dt_from_string($value, 'iso'))
>                         if defined $value;
>                 }
>                 else {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24850: 100585 | 100586 | 100587 | 100592 | 100593 | 100594 | 100595 | 100678 | 100679 | 100680 | 100681 | 100881 | 100901 | 100902 | 100903 | 100904 | 100905 | 101803 | 101804 | 101805 | 101806 | 101807 | 101808 | 101837 | 101838 | 101839 | 101840 | 101841 | 101842 | 101843 | 101844 | 115851 | 115852 | 115853 | 115854 | 115855 | 115856 | 115857 | 116299 | 116300 | 116301 | 116302 | 116303 | 116304 | 116305 | 116355 | 116356 | 116357 | 116358 | 116359 | 116360 | 116361 | 116511 | 126182 | 126183 | 126184 | 126185 | 126186 | 126187 | 126188 | 126189 | 127231 | 127232 | 127235 | 127236 | 127239 | 127240 | 127241 | 127242 | 127243 | 127244