Attachment 127310 Details for Bug 27631 – Bug 27631: (follow-up) reports/guided_reports_start.tt

[patch] Bug 27631: (follow-up) reports/guided_reports_start.tt

Bug-27631-follow-up-reportsguidedreportsstarttt.patch (text/plain), 2.26 KB, created by Owen Leonard on 2021-11-04 11:56:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2021-11-04 11:56:36 UTC

Size: 2.26 KB

patch

obsolete

>From eda61c678ad1d39c8e547d9c3fd5612d16b48f02 Mon Sep 17 00:00:00 2001
>From: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
>Date: Tue, 1 Jun 2021 04:40:40 +0000
>Subject: [PATCH] Bug 27631: (follow-up) reports/guided_reports_start.tt
>
>Changed file to have one <h1> tag showing that describes the page,
>rather than the <h1> around the logo.
>
>The hierarchy of other heading tags may be wrong, but this wil be dealt
>with in an additional bug.
>
>To test:
>1) Go to the Staff Client
>2) Apply patch
>3) Go to reports/guided_reports_start and check that it has an obvious
>   and descriptive heading
>4) Ensure that the heading is <h1>
>
>Sponsored-by: Catalyst IT
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> .../prog/en/modules/reports/guided_reports_start.tt           | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 30568ea307..92756999c5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -774,7 +774,7 @@
>                         <input type="hidden" name="public" value="[% public | html %]" />
>                         <input type="hidden" name="cache_expiry" value="[% cache_expiry | html %]" />
>                         <fieldset class="rows">
>-                            <legend>Save your custom report</legend>
>+                            <legend><h1>Save your custom report</h1></legend>
>                             <ol>
>                                 <li>
>                                     <label for="reportname" class="required">Report name: </label>
>@@ -1242,7 +1242,7 @@
>                         <input type="hidden" name="phase" value="Update SQL" />
>                         <input type="hidden" name="id" value="[% id | html %]"/>
>                         <fieldset class="rows">
>-                            <legend>Edit SQL report</legend>
>+                            <legend><h1>Edit SQL report</h1></legend>
>                             <ol>
>                                 <li>
>                                     <label for="reportname" class="required">Report name: </label>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27631: 116352 | 119492 | 119493 | 119496 | 119497 | 119498 | 119500 | 119501 | 119502 | 119544 | 119545 | 119546 | 119547 | 119830 | 119831 | 119832 | 119834 | 119835 | 119836 | 119837 | 119838 | 119839 | 119840 | 119841 | 119842 | 119843 | 120158 | 120159 | 120160 | 120161 | 120162 | 120166 | 120190 | 120191 | 121356 | 121469 | 121470 | 121522 | 121559 | 125547 | 125548 | 125549 | 125550 | 125551 | 125552 | 125553 | 125554 | 125555 | 125556 | 125557 | 125558 | 125559 | 125560 | 125561 | 125562 | 125563 | 125564 | 127295 | 127296 | 127297 | 127298 | 127299 | 127300 | 127301 | 127302 | 127303 | 127304 | 127305 | 127306 | 127307 | 127308 | 127309 | 127310 | 127311 | 127312 | 127432 | 127433 | 127449 | 127456 | 131069 | 131070 | 131071 | 131072 | 131073 | 131074 | 131075 | 131076 | 131077 | 131078 | 131079 | 131080 | 131081 | 131082 | 131083 | 131084 | 131085 | 131086 | 131087 | 131192 | 132886 | 132887 | 132888 | 132889 | 132890 | 132891 | 132892 | 132893 | 132894 | 132895 | 132896 | 132897 | 132898 | 132899 | 132900 | 132901 | 132902 | 132903 | 132904 | 132905