Bugzilla – Attachment 127342 Details for
Bug 27266
Move C4::Biblio::GetMarcAuthors to Koha namespace
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27266: (QA follow-up) Remove GetBiblioData from sendshelf too
Bug-27266-QA-follow-up-Remove-GetBiblioData-from-s.patch (text/plain), 2.56 KB, created by
Marcel de Rooy
on 2021-11-05 08:38:58 UTC
(
hide
)
Description:
Bug 27266: (QA follow-up) Remove GetBiblioData from sendshelf too
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-11-05 08:38:58 UTC
Size:
2.56 KB
patch
obsolete
>From 68bc16634a4f201c143d572dd6b30e040ddc6ad4 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 5 Nov 2021 07:57:51 +0000 >Subject: [PATCH] Bug 27266: (QA follow-up) Remove GetBiblioData from sendshelf > too >Content-Type: text/plain; charset=utf-8 > >Applies to opac and intranet script. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > opac/opac-sendshelf.pl | 5 ++--- > virtualshelves/sendshelf.pl | 5 ++--- > 2 files changed, 4 insertions(+), 6 deletions(-) > >diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl >index aa4eba2187..4b33d8ef97 100755 >--- a/opac/opac-sendshelf.pl >+++ b/opac/opac-sendshelf.pl >@@ -26,7 +26,6 @@ use Try::Tiny qw( catch try ); > > use C4::Auth qw( get_template_and_user ); > use C4::Biblio qw( >- GetBiblioData > GetFrameworkCode > GetMarcBiblio > GetMarcISBN >@@ -84,15 +83,15 @@ if ( $shelf and $shelf->can_be_viewed( $borrowernumber ) ) { > > while ( my $content = $contents->next ) { > my $biblionumber = $content->biblionumber; >+ my $biblio = Koha::Biblios->find( $biblionumber ) or next; >+ my $dat = $biblio->unblessed; > my $record = GetMarcBiblio({ > biblionumber => $biblionumber, > embed_items => 1, > opac => 1, > borcat => $borcat }); > next unless $record; >- my $biblio = Koha::Biblios->find( $biblionumber ); > my $fw = GetFrameworkCode($biblionumber); >- my $dat = GetBiblioData($biblionumber); > > my $marcauthorsarray = $biblio->get_marc_authors; > my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour ); >diff --git a/virtualshelves/sendshelf.pl b/virtualshelves/sendshelf.pl >index acb1a52d1d..06649a9889 100755 >--- a/virtualshelves/sendshelf.pl >+++ b/virtualshelves/sendshelf.pl >@@ -26,7 +26,6 @@ use Try::Tiny qw( catch try ); > > use C4::Auth qw( get_template_and_user ); > use C4::Biblio qw( >- GetBiblioData > GetMarcBiblio > GetMarcISBN > GetMarcSubjects >@@ -72,8 +71,8 @@ if ($to_address) { > > while ( my $content = $contents->next ) { > my $biblionumber = $content->biblionumber; >- my $biblio = Koha::Biblios->find( $biblionumber ); >- my $dat = GetBiblioData($biblionumber); >+ my $biblio = Koha::Biblios->find( $biblionumber ) or next; >+ my $dat = $biblio->unblessed; > my $record = GetMarcBiblio({ > biblionumber => $biblionumber, > embed_items => 1 }); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27266
:
114503
|
114580
|
117239
|
118311
|
118312
|
123017
|
123018
|
123019
|
123026
|
123027
|
123028
|
123067
|
125440
|
125441
|
125442
|
125443
|
125444
|
125465
|
125466
|
125467
|
125468
|
125469
|
125719
|
125720
|
125721
|
125722
|
125723
|
126539
|
126540
|
126541
|
126542
|
126543
|
127330
|
127331
|
127332
|
127333
|
127334
|
127335
|
127336
|
127337
|
127340
|
127341
|
127342
|
127561
|
127562
|
127563
|
127564
|
127565
|
127566
|
127567
|
127568