Attachment 127410 Details for Bug 29204 – Bug 29204: (QA follow-up) Fix variable name

[patch] Bug 29204: (QA follow-up) Fix variable name

Bug-29204-QA-follow-up-Fix-variable-name.patch (text/plain), 1.27 KB, created by Joonas Kylmälä on 2021-11-06 14:19:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2021-11-06 14:19:41 UTC

Size: 1.27 KB

patch

obsolete

>From 1bb7b601ad0eebaa541a32f4fa1baaca80fa5051 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi>
>Date: Sat, 6 Nov 2021 14:16:38 +0000
>Subject: [PATCH] Bug 29204: (QA follow-up) Fix variable name
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>The patch "Bug 29204: Fix reports/issues_stats.pl for MySQL 8"
>accidentally changed the variable name from $strsth2 to $strsth
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@iki.fi>
>---
> reports/issues_stats.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/reports/issues_stats.pl b/reports/issues_stats.pl
>index a9f6716e4c..f5209b2ff8 100755
>--- a/reports/issues_stats.pl
>+++ b/reports/issues_stats.pl
>@@ -401,8 +401,8 @@ sub calculate {
>           ( $colsource eq 'items' )
>           ? "LEFT JOIN items ON (statistics.itemnumber = items.itemnumber) "
>           : "LEFT JOIN borrowers ON (statistics.borrowernumber = borrowers.borrowernumber) ";
>-        $strsth .= " WHERE $column IS NOT NULL";
>-        $strsth .= " AND $column != '' " if $column ne "datetime";
>+        $strsth2 .= " WHERE $column IS NOT NULL";
>+        $strsth2 .= " AND $column != '' " if $column ne "datetime";
>     }
> 
>     if ( $column =~ /datetime/ ) {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29204: 126475 | 127409 | 127410 | 127442 | 127443