Attachment 127428 Details for Bug 29427 – Bug 29427: Make SMTP transport set debug mode correctly

[patch] Bug 29427: Make SMTP transport set debug mode correctly

Bug-29427-Make-SMTP-transport-set-debug-mode-corre.patch (text/plain), 1.22 KB, created by Martin Renvoize (ashimema) on 2021-11-08 08:52:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-11-08 08:52:38 UTC

Size: 1.22 KB

patch

obsolete

>From c62b7f4762f29d1ea5e778c9dcb25fb1aa05f612 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 5 Nov 2021 12:50:35 -0300
>Subject: [PATCH] Bug 29427: Make SMTP transport set debug mode correctly
>
>This patch makes the _transport_ method in Koha::SMTP::Server pass the
>debug flag correctly to the Email::Sender::Transport::SMTP->new
>constructor.
>
>To test:
>1. Apply the regression tests patch
>2. Run:
>   $ kshell
>  k$ prove t/db_dependent/Koha/SMTP/Server.t
>=> FAIL: Oh noes! debug is not passed to the constructor!
>3. Apply this patch
>4. Repeat 2
>=> SUCCESS: Hey! It is being set!
>5. Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/SMTP/Server.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/Koha/SMTP/Server.pm b/Koha/SMTP/Server.pm
>index d5fec72611..7a2a40cb18 100644
>--- a/Koha/SMTP/Server.pm
>+++ b/Koha/SMTP/Server.pm
>@@ -64,6 +64,7 @@ sub transport {
>     $params->{sasl_password} = $self->password
>         if $self->password;
> 
>+    $params->{debug} = $self->debug;
> 
>     my $transport = Email::Sender::Transport::SMTP->new( $params );
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29427: 127397 | 127398 | 127402 | 127403 | 127427 | 127428