Bugzilla – Attachment 127431 Details for
Bug 29387
BatchUpdateBiblio does not handle exception correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29387: Strinfigy exceptions for other background job modules
Bug-29387-Strinfigy-exceptions-for-other-backgroun.patch (text/plain), 2.71 KB, created by
Jonathan Druart
on 2021-11-08 09:23:40 UTC
(
hide
)
Description:
Bug 29387: Strinfigy exceptions for other background job modules
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-11-08 09:23:40 UTC
Size:
2.71 KB
patch
obsolete
>From 21f8e0ada3f811a0495fea4fb60bf9df242908be Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 8 Nov 2021 10:22:09 +0100 >Subject: [PATCH] Bug 29387: Strinfigy exceptions for other background job > modules > >--- > Koha/BackgroundJob/BatchCancelHold.pm | 2 +- > Koha/BackgroundJob/BatchDeleteAuthority.pm | 2 +- > Koha/BackgroundJob/BatchDeleteBiblio.pm | 2 +- > Koha/BackgroundJob/BatchUpdateAuthority.pm | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/BackgroundJob/BatchCancelHold.pm b/Koha/BackgroundJob/BatchCancelHold.pm >index cc9ec6ad3c5..5216119ac16 100644 >--- a/Koha/BackgroundJob/BatchCancelHold.pm >+++ b/Koha/BackgroundJob/BatchCancelHold.pm >@@ -94,7 +94,7 @@ sub process { > biblio_id => defined $biblio ? $biblio->biblionumber : '', > hold_id => $hold_id, > error => defined $hold >- ? ( $@ ? $@ : 0 ) >+ ? ( $@ ? "$@" : 0 ) > : 'hold_not_found', > }; > } >diff --git a/Koha/BackgroundJob/BatchDeleteAuthority.pm b/Koha/BackgroundJob/BatchDeleteAuthority.pm >index 18a3202a6ea..99833abcd60 100644 >--- a/Koha/BackgroundJob/BatchDeleteAuthority.pm >+++ b/Koha/BackgroundJob/BatchDeleteAuthority.pm >@@ -57,7 +57,7 @@ sub process { > type => 'error', > code => 'authority_not_deleted', > authid => $authid, >- error => ($@ ? $@ : 0), >+ error => "$@", > }; > $schema->storage->txn_rollback; > next; >diff --git a/Koha/BackgroundJob/BatchDeleteBiblio.pm b/Koha/BackgroundJob/BatchDeleteBiblio.pm >index c1077716af4..69317592866 100644 >--- a/Koha/BackgroundJob/BatchDeleteBiblio.pm >+++ b/Koha/BackgroundJob/BatchDeleteBiblio.pm >@@ -101,7 +101,7 @@ sub process { > code => 'reserve_not_cancelled', > biblionumber => $biblionumber, > reserve_id => $hold->reserve_id, >- error => $@, >+ error => "$@", > }; > $schema->storage->txn_rollback; > $job->progress( ++$job_progress )->store; >diff --git a/Koha/BackgroundJob/BatchUpdateAuthority.pm b/Koha/BackgroundJob/BatchUpdateAuthority.pm >index 5969a1311d5..9eacf58a5fe 100644 >--- a/Koha/BackgroundJob/BatchUpdateAuthority.pm >+++ b/Koha/BackgroundJob/BatchUpdateAuthority.pm >@@ -90,7 +90,7 @@ sub process { > type => 'error', > code => 'authority_not_modified', > authid => $authid, >- error => ($@ ? $@ : 0), >+ error => ($@ ? "$@" : 0), > }; > } else { > push @messages, { >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29387
:
127205
|
127207
|
127431
|
127594
|
127595
|
127825
|
127826
|
127827
|
127924