Attachment 127442 Details for Bug 29204 – Bug 29204: Fix reports/issues_stats.pl for MySQL 8

[patch] Bug 29204: Fix reports/issues_stats.pl for MySQL 8

Bug-29204-Fix-reportsissuesstatspl-for-MySQL-8.patch (text/plain), 1.76 KB, created by Martin Renvoize (ashimema) on 2021-11-08 12:02:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-11-08 12:02:05 UTC

Size: 1.76 KB

patch

obsolete

>From d2dbc92a435480f9a5fdce26af3f22a735d00c4d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 19 Oct 2021 11:08:29 +0200
>Subject: [PATCH] Bug 29204: Fix reports/issues_stats.pl for MySQL 8
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Error was: Incorrect DATETIME value: ''
>
>Test plan
>Go to Reports -> Circulation
>On Period select "Row" or "Column" and choose a date
>Submit
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@iki.fi>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> reports/issues_stats.pl | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/reports/issues_stats.pl b/reports/issues_stats.pl
>index 3eb27fb3e2..a9f6716e4c 100755
>--- a/reports/issues_stats.pl
>+++ b/reports/issues_stats.pl
>@@ -312,7 +312,8 @@ sub calculate {
>           ( $linesource eq 'items' )
>           ? " LEFT JOIN items ON (statistics.itemnumber = items.itemnumber) "
>           : " LEFT JOIN borrowers ON (statistics.borrowernumber = borrowers.borrowernumber) ";
>-        $strsth .= " WHERE $line is not null AND $line != '' ";
>+        $strsth .= " WHERE $line IS NOT NULL ";
>+        $strsth .= " AND $line != '' " if $line ne "datetime";
>     }
> 
>     if ( $line =~ /datetime/ ) {
>@@ -400,7 +401,8 @@ sub calculate {
>           ( $colsource eq 'items' )
>           ? "LEFT JOIN items ON (statistics.itemnumber = items.itemnumber) "
>           : "LEFT JOIN borrowers ON (statistics.borrowernumber = borrowers.borrowernumber) ";
>-        $strsth2 .= " WHERE $column IS NOT NULL AND $column != '' ";
>+        $strsth .= " WHERE $column IS NOT NULL";
>+        $strsth .= " AND $column != '' " if $column ne "datetime";
>     }
> 
>     if ( $column =~ /datetime/ ) {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29204: 126475 | 127409 | 127410 | 127442 | 127443