Attachment 127588 Details for Bug 21105 – Bug 21105: (QA follow-up) Silence warning because of tests setup

[patch] Bug 21105: (QA follow-up) Silence warning because of tests setup

Bug-21105-QA-follow-up-Silence-warning-because-of-.patch (text/plain), 1.31 KB, created by Tomás Cohen Arazi (tcohen) on 2021-11-12 14:37:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-11-12 14:37:46 UTC

Size: 1.31 KB

patch

obsolete

>From 56059e953556467c2f4a4db67ba9c22f86cdf185 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 12 Nov 2021 11:15:08 -0300
>Subject: [PATCH] Bug 21105: (QA follow-up) Silence warning because of tests
> setup
>
>The tests are using 'http://localhost' and the regex is setting $baseURL
>to empty in this case. It works on the oai.pl front-end.
>
>This patch changes the regex.
>
>To test:
>1. Run:
>   $ kshell
>  k$ t/db_dependent/OAI/Server.t
>=> FAIL: Boo! Warning!
>2. Apply this patch
>3. Repeat 2
>=> SUCCESS: Oh, cool. No warning :-D
>4. Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/OAI/Server/Identify.pm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/OAI/Server/Identify.pm b/Koha/OAI/Server/Identify.pm
>index 7afccef737..a44df73b40 100644
>--- a/Koha/OAI/Server/Identify.pm
>+++ b/Koha/OAI/Server/Identify.pm
>@@ -28,7 +28,10 @@ use base ("HTTP::OAI::Identify");
> sub new {
>     my ($class, $repository) = @_;
> 
>-    my ($baseURL) = $repository->self_url() =~ /(.*)\?.*/;
>+    my $baseURL = $repository->self_url();
>+    $baseURL = $+{base_url}
>+        if $baseURL =~ m/(?<base_url>.*)\?.*/;
>+
>     my $self = $class->SUPER::new(
>         baseURL             => $baseURL,
>         repositoryName      => C4::Context->preference("LibraryName"),
>-- 
>2.32.0

Actions: View | Diff | Splinter Review

Attachments on bug 21105: 119604 | 119692 | 126236 | 126240 | 126241 | 127586 | 127587 | 127588 | 127589 | 127628 | 127644 | 127650 | 127653