Attachment 127751 Details for Bug 29506 – Bug 29506: Regression tests

[patch] Bug 29506: Regression tests

Bug-29506-Regression-tests.patch (text/plain), 3.25 KB, created by Tomás Cohen Arazi (tcohen) on 2021-11-17 18:01:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-11-17 18:01:28 UTC

Size: 3.25 KB

patch

obsolete

>From 7ac3c50ee9b9c3642e0a58521e6fdfc9249cd61d Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Wed, 17 Nov 2021 14:30:11 -0300
>Subject: [PATCH] Bug 29506: Regression tests
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> t/db_dependent/Koha/REST/Plugin/Objects.t | 68 ++++++++++++++++++++++-
> 1 file changed, 67 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/REST/Plugin/Objects.t b/t/db_dependent/Koha/REST/Plugin/Objects.t
>index 9bff09d9c4..8deee9da7d 100755
>--- a/t/db_dependent/Koha/REST/Plugin/Objects.t
>+++ b/t/db_dependent/Koha/REST/Plugin/Objects.t
>@@ -20,6 +20,9 @@ use Modern::Perl;
> use Koha::Acquisition::Orders;
> use Koha::Cities;
> use Koha::Biblios;
>+use Koha::Patrons;
>+
>+use Mojo::JSON qw(encode_json);
> 
> # Dummy app for testing the plugin
> use Mojolicious::Lite;
>@@ -101,8 +104,20 @@ get '/libraries/:library_id_1/:library_id_2' => sub {
>     );
> };
> 
>+get '/my_patrons' => sub {
>+
>+    my $c = shift;
>+
>+    my $patrons = $c->objects->search( scalar Koha::Patrons->search( {}, { order_by   => 'borrowernumber' }) );
>+
>+    $c->render(
>+        status => 200,
>+        json   => $patrons
>+    );
>+};
>+
> # The tests
>-use Test::More tests => 13;
>+use Test::More tests => 14;
> use Test::Mojo;
> 
> use t::lib::Mocks;
>@@ -552,3 +567,54 @@ subtest 'objects.search helper, public requests' => sub {
> 
>     $schema->storage->txn_rollback;
> };
>+
>+subtest 'objects.search helper, search_limited() tests' => sub {
>+
>+    plan tests => 9;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $library_1 = $builder->build_object({ class => 'Koha::Libraries' });
>+    my $library_2 = $builder->build_object({ class => 'Koha::Libraries' });
>+
>+    my $patron_1 = $builder->build_object({ class => 'Koha::Patrons', value => { branchcode => $library_1->id } });
>+    my $patron_2 = $builder->build_object({ class => 'Koha::Patrons', value => { branchcode => $library_1->id } });
>+    my $patron_3 = $builder->build_object({ class => 'Koha::Patrons', value => { branchcode => $library_2->id } });
>+
>+    my @libraries_where_can_see_patrons = ( $library_1->id, $library_2->id );
>+
>+    my $t = Test::Mojo->new;
>+
>+    my $mocked_patron = Test::MockModule->new('Koha::Patron');
>+    $mocked_patron->mock( 'libraries_where_can_see_patrons', sub
>+        {
>+            return @libraries_where_can_see_patrons;
>+        }
>+    );
>+
>+    my $patron = $builder->build_object(
>+        {
>+            class => 'Koha::Patrons',
>+            value => { flags => 2**4 }    # borrowers flag = 4
>+        }
>+    );
>+
>+    t::lib::Mocks::mock_userenv({ patron => $patron });
>+
>+    $t->get_ok( "/my_patrons?q=" . encode_json( { library_id => [ $library_1->id, $library_2->id ] } ) )
>+      ->status_is(200)
>+      ->json_is( '/0/patron_id' => $patron_1->id )
>+      ->json_is( '/1/patron_id' => $patron_2->id )
>+      ->json_is( '/2/patron_id' => $patron_3->id );
>+
>+    @libraries_where_can_see_patrons = ( $library_2->id );
>+
>+    my $res = $t->get_ok( "/my_patrons?q=" . encode_json( { library_id => [ $library_1->id, $library_2->id ] } ) )
>+      ->status_is(200)
>+      ->json_is( '/0/patron_id' => $patron_3->id, 'Returns the only allowed patron' )
>+      ->tx->res->json;
>+
>+    is( scalar @{$res}, 1, 'Only one patron returned' );
>+
>+    $schema->storage->txn_rollback;
>+};
>-- 
>2.34.0

Actions: View | Diff | Splinter Review

Attachments on bug 29506: 127751 | 127752 | 127753 | 127754 | 127755 | 127756 | 128668 | 128669 | 128670 | 129299 | 129300 | 129301