Bugzilla – Attachment 127772 Details for
Bug 29510
objects.find should call search_limited if present
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29510: Regression tests
Bug-29510-Regression-tests.patch (text/plain), 2.76 KB, created by
Martin Renvoize (ashimema)
on 2021-11-18 07:56:11 UTC
(
hide
)
Description:
Bug 29510: Regression tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-11-18 07:56:11 UTC
Size:
2.76 KB
patch
obsolete
>From f5e9843e9543e844a1279e54e179c3bb8277723f Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 17 Nov 2021 18:02:17 -0300 >Subject: [PATCH] Bug 29510: Regression tests > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Koha/REST/Plugin/Objects.t | 63 ++++++++++++++++++++++- > 1 file changed, 62 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/REST/Plugin/Objects.t b/t/db_dependent/Koha/REST/Plugin/Objects.t >index 8deee9da7d..364750f933 100755 >--- a/t/db_dependent/Koha/REST/Plugin/Objects.t >+++ b/t/db_dependent/Koha/REST/Plugin/Objects.t >@@ -116,8 +116,21 @@ get '/my_patrons' => sub { > ); > }; > >+get '/my_patrons/:patron_id' => sub { >+ >+ my $c = shift; >+ >+ my $patron_id = $c->param('patron_id'); >+ my $patron = $c->objects->find( scalar Koha::Patrons->new, $patron_id ); >+ >+ $c->render( >+ status => 200, >+ json => $patron >+ ); >+}; >+ > # The tests >-use Test::More tests => 14; >+use Test::More tests => 15; > use Test::Mojo; > > use t::lib::Mocks; >@@ -618,3 +631,51 @@ subtest 'objects.search helper, search_limited() tests' => sub { > > $schema->storage->txn_rollback; > }; >+ >+subtest 'objects.find helper, search_limited() tests' => sub { >+ >+ plan tests => 12; >+ >+ $schema->storage->txn_begin; >+ >+ my $library_1 = $builder->build_object({ class => 'Koha::Libraries' }); >+ my $library_2 = $builder->build_object({ class => 'Koha::Libraries' }); >+ >+ my $patron_1 = $builder->build_object({ class => 'Koha::Patrons', value => { branchcode => $library_1->id } }); >+ my $patron_2 = $builder->build_object({ class => 'Koha::Patrons', value => { branchcode => $library_2->id } }); >+ >+ my @libraries_where_can_see_patrons = ( $library_1->id, $library_2->id ); >+ >+ my $t = Test::Mojo->new; >+ >+ my $mocked_patron = Test::MockModule->new('Koha::Patron'); >+ $mocked_patron->mock( 'libraries_where_can_see_patrons', sub >+ { >+ return @libraries_where_can_see_patrons; >+ } >+ ); >+ >+ my $patron = $builder->build_object({ class => 'Koha::Patrons' }); >+ >+ t::lib::Mocks::mock_userenv({ patron => $patron }); >+ >+ $t->get_ok( "/my_patrons/" . $patron_1->id ) >+ ->status_is(200) >+ ->json_is( '/patron_id' => $patron_1->id ); >+ >+ $t->get_ok( "/my_patrons/" . $patron_2->id ) >+ ->status_is(200) >+ ->json_is( '/patron_id' => $patron_2->id ); >+ >+ @libraries_where_can_see_patrons = ( $library_2->id ); >+ >+ $t->get_ok( "/my_patrons/" . $patron_1->id ) >+ ->status_is(200) >+ ->json_is( undef ); >+ >+ $t->get_ok( "/my_patrons/" . $patron_2->id ) >+ ->status_is(200) >+ ->json_is( '/patron_id' => $patron_2->id ); >+ >+ $schema->storage->txn_rollback; >+}; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29510
:
127759
|
127760
|
127761
|
127772
|
127773
|
127774
|
161253
|
161254
|
161255
|
161477
|
161478
|
161479