Bugzilla – Attachment 127826 Details for
Bug 29387
BatchUpdateBiblio does not handle exception correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29387: Stringify exceptions for other background job modules
Bug-29387-Stringify-exceptions-for-other-backgroun.patch (text/plain), 2.94 KB, created by
Marcel de Rooy
on 2021-11-19 07:43:39 UTC
(
hide
)
Description:
Bug 29387: Stringify exceptions for other background job modules
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-11-19 07:43:39 UTC
Size:
2.94 KB
patch
obsolete
>From ebc3b5a6301a8c5a6e734b8216c8571f6e89d2ab Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 8 Nov 2021 10:22:09 +0100 >Subject: [PATCH] Bug 29387: Stringify exceptions for other background job > modules >MIME-Version: 1.0 >Content-Type: text/plain; charset=utf-8 >Content-Transfer-Encoding: 8bit >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/BackgroundJob/BatchCancelHold.pm | 2 +- > Koha/BackgroundJob/BatchDeleteAuthority.pm | 2 +- > Koha/BackgroundJob/BatchDeleteBiblio.pm | 2 +- > Koha/BackgroundJob/BatchUpdateAuthority.pm | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/BackgroundJob/BatchCancelHold.pm b/Koha/BackgroundJob/BatchCancelHold.pm >index cc9ec6ad3c..5216119ac1 100644 >--- a/Koha/BackgroundJob/BatchCancelHold.pm >+++ b/Koha/BackgroundJob/BatchCancelHold.pm >@@ -94,7 +94,7 @@ sub process { > biblio_id => defined $biblio ? $biblio->biblionumber : '', > hold_id => $hold_id, > error => defined $hold >- ? ( $@ ? $@ : 0 ) >+ ? ( $@ ? "$@" : 0 ) > : 'hold_not_found', > }; > } >diff --git a/Koha/BackgroundJob/BatchDeleteAuthority.pm b/Koha/BackgroundJob/BatchDeleteAuthority.pm >index 18a3202a6e..99833abcd6 100644 >--- a/Koha/BackgroundJob/BatchDeleteAuthority.pm >+++ b/Koha/BackgroundJob/BatchDeleteAuthority.pm >@@ -57,7 +57,7 @@ sub process { > type => 'error', > code => 'authority_not_deleted', > authid => $authid, >- error => ($@ ? $@ : 0), >+ error => "$@", > }; > $schema->storage->txn_rollback; > next; >diff --git a/Koha/BackgroundJob/BatchDeleteBiblio.pm b/Koha/BackgroundJob/BatchDeleteBiblio.pm >index c1077716af..6931759286 100644 >--- a/Koha/BackgroundJob/BatchDeleteBiblio.pm >+++ b/Koha/BackgroundJob/BatchDeleteBiblio.pm >@@ -101,7 +101,7 @@ sub process { > code => 'reserve_not_cancelled', > biblionumber => $biblionumber, > reserve_id => $hold->reserve_id, >- error => $@, >+ error => "$@", > }; > $schema->storage->txn_rollback; > $job->progress( ++$job_progress )->store; >diff --git a/Koha/BackgroundJob/BatchUpdateAuthority.pm b/Koha/BackgroundJob/BatchUpdateAuthority.pm >index 5969a1311d..9eacf58a5f 100644 >--- a/Koha/BackgroundJob/BatchUpdateAuthority.pm >+++ b/Koha/BackgroundJob/BatchUpdateAuthority.pm >@@ -90,7 +90,7 @@ sub process { > type => 'error', > code => 'authority_not_modified', > authid => $authid, >- error => ($@ ? $@ : 0), >+ error => ($@ ? "$@" : 0), > }; > } else { > push @messages, { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29387
:
127205
|
127207
|
127431
|
127594
|
127595
|
127825
| 127826 |
127827
|
127924