Bugzilla – Attachment 127857 Details for
Bug 29113
New "code" field for additional contents is not useful for the end users
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29113: Fix random assignation
Bug-29113-Fix-random-assignation.patch (text/plain), 3.97 KB, created by
Marcel de Rooy
on 2021-11-19 10:53:17 UTC
(
hide
)
Description:
Bug 29113: Fix random assignation
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-11-19 10:53:17 UTC
Size:
3.97 KB
patch
obsolete
>From 5a96e88176992d4f69157c23c2e06865be3f3aba Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 7 Oct 2021 10:06:15 +0200 >Subject: [PATCH] Bug 29113: Fix random assignation >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../prog/en/modules/tools/additional-contents.tt | 6 +++--- > tools/additional-contents.pl | 6 ++---- > 2 files changed, 5 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >index 9a3932ef07..de1afef40e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >@@ -202,7 +202,7 @@ > [% UNLESS languages.size %] > <li> > <label for="title" class="required">Title: </label> >- <input id="title" size="100" maxlength="250" type="text" name="title" value="[% additional_content.title | html %]" required="required" class="required" /> <span class="required">Required</span> >+ <input id="title" size="100" maxlength="250" type="text" name="title_default" value="[% additional_content.title | html %]" required="required" class="required" /> <span class="required">Required</span> > </li> > [% END %] > <li> >@@ -250,11 +250,11 @@ > <ol> > <li style="list-style: none;"> > <label for="title_[% language.lang | html %]">Title: </label> >- <input id="title_[% language.lang| html %]" size="100" maxlength="250" type="text" name="title" value="[% translated_contents.item(language.lang).title | html %]"> >+ <input id="title_[% language.lang| html %]" size="100" maxlength="250" type="text" name="title_[% language.lang | html %]" value="[% translated_contents.item(language.lang).title | html %]"> > </li> > <li style="list-style: none;"> > <label for="content_[% language.lang | html %]">Content: </label> >- <textarea name="content" id="content_[% language.lang | html %]" data-lang="[% language.lang | html%]" cols="75" rows="10">[% translated_contents.item(language.lang).content | html %]</textarea> >+ <textarea name="content_[% language.lang | html %]" id="content_[% language.lang | html %]" data-lang="[% language.lang | html%]" cols="75" rows="10">[% translated_contents.item(language.lang).content | html %]</textarea> > <input type="hidden" name="lang" value="[% language.lang | html %]" /> > </li> > </ol> >diff --git a/tools/additional-contents.pl b/tools/additional-contents.pl >index dcbc8d7a79..e63a44a809 100755 >--- a/tools/additional-contents.pl >+++ b/tools/additional-contents.pl >@@ -83,8 +83,6 @@ elsif ( $op eq 'add_validate' ) { > my $code = $cgi->param('code'); > my $branchcode = $cgi->param('branchcode') || undef; > >- my @title = $cgi->multi_param('title'); >- my @content = $cgi->multi_param('content'); > my @lang = $cgi->multi_param('lang'); > > my $expirationdate; >@@ -108,8 +106,8 @@ elsif ( $op eq 'add_validate' ) { > > my $success = 1; > for my $lang ( sort {$a ne 'default'} @lang ) { # Process 'default' first >- my $title = shift @title; >- my $content = shift @content; >+ my $title = $cgi->param( 'title_' . $lang ); >+ my $content = $cgi->param( 'content_' . $lang ); > my $additional_content = Koha::AdditionalContents->find( > { > category => $category, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29113
:
125695
|
125696
|
125861
|
127365
|
127856
|
127857
|
127989
|
127990