Attachment 127888 Details for Bug 29523 – Bug 29523: Regression tests

[patch] Bug 29523: Regression tests

Bug-29523-Regression-tests.patch (text/plain), 1.98 KB, created by Tomás Cohen Arazi (tcohen) on 2021-11-19 16:26:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-11-19 16:26:15 UTC

Size: 1.98 KB

patch

obsolete

>From 4195d16224db39aeb1ab30baac47cce17cb345a8 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 19 Nov 2021 13:12:14 -0300
>Subject: [PATCH] Bug 29523: Regression tests
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> t/db_dependent/Koha/Object.t | 36 +++++++++++++++++++++++++++++++++++-
> 1 file changed, 35 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Object.t b/t/db_dependent/Koha/Object.t
>index 39449745db..66f4b9dfa3 100755
>--- a/t/db_dependent/Koha/Object.t
>+++ b/t/db_dependent/Koha/Object.t
>@@ -223,7 +223,7 @@ subtest 'TO_JSON tests' => sub {
> 
> subtest "to_api() tests" => sub {
> 
>-    plan tests => 29;
>+    plan tests => 30;
> 
>     $schema->storage->txn_begin;
> 
>@@ -420,6 +420,40 @@ subtest "to_api() tests" => sub {
>         }
>     };
> 
>+    subtest 'accessible usage tests' => sub {
>+
>+        plan tests => 2;
>+
>+        $schema->storage->txn_begin;
>+
>+        my $library_1 = $builder->build_object( { class => 'Koha::Libraries' } );
>+        my $library_2 = $builder->build_object( { class => 'Koha::Libraries' } );
>+
>+        my $patron = $builder->build_object(
>+            {
>+                class => 'Koha::Patrons',
>+                value => {
>+                    flags      => 2**2,            # only has catalogue permissions
>+                    branchcode => $library_1->id
>+                }
>+            }
>+        );
>+
>+        my $patron_1 = $builder->build_object(
>+            { class => 'Koha::Patrons', value => { branchcode => $library_1->id } }
>+        );
>+        my $patron_2 = $builder->build_object(
>+            { class => 'Koha::Patrons', value => { branchcode => $library_2->id } }
>+        );
>+
>+        t::lib::Mocks::mock_userenv( { patron => $patron } );
>+
>+        is( ref($patron_1->to_api), 'HASH', 'Returns the object hash' );
>+        is( $patron_2->to_api, undef, 'Not accessible, returns undef' );
>+
>+        $schema->storage->txn_rollback;
>+    };
>+
>     $schema->storage->txn_rollback;
> };
> 
>-- 
>2.32.0

Actions: View | Diff | Splinter Review

Attachments on bug 29523: 127886 | 127887 | 127888 | 127889 | 127991 | 127992 | 127993 | 127994 | 128042 | 128043 | 128044 | 128045 | 128046 | 128047 | 128048 | 128688 | 128689 | 128690 | 128691 | 128692 | 128693 | 128694 | 131326 | 131331 | 131332 | 136684 | 136685 | 136686 | 136687 | 136688 | 136689 | 136690 | 136691 | 136692 | 136706 | 136714 | 148736 | 148737 | 148738 | 148739 | 148740 | 148741 | 148742 | 148743 | 148744 | 148745 | 150989 | 150990 | 150991 | 150992 | 150993 | 150994 | 150995 | 150996 | 150997 | 150998 | 156939 | 156940 | 156941 | 156942 | 156943 | 156944 | 156945 | 156946 | 156947 | 156948 | 156949 | 156965 | 157049 | 157071 | 157072 | 157073 | 157074 | 157075 | 157076 | 157077 | 157078 | 157079 | 157080 | 157081 | 157406 | 157407 | 157408 | 157409 | 157410 | 157411 | 157412 | 157413 | 157414 | 157415 | 157416 | 157673 | 157679 | 157683 | 157799 | 157881 | 157882 | 157883 | 157884 | 157885 | 157886 | 157887 | 157888 | 157889 | 157890 | 157891 | 157892 | 157893 | 158013