Bugzilla – Attachment 127927 Details for
Bug 29554
neworderempty.pl may create records with biblioitems.itemtype NULL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29554: Do not hide display of itemtypes on neworderempty
Bug-29554-Do-not-hide-display-of-itemtypes-on-newo.patch (text/plain), 1.20 KB, created by
Marcel de Rooy
on 2021-11-22 13:03:15 UTC
(
hide
)
Description:
Bug 29554: Do not hide display of itemtypes on neworderempty
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-11-22 13:03:15 UTC
Size:
1.20 KB
patch
obsolete
>From 34c688980f47f7f0354d236eada9c9d22e3828e6 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 22 Nov 2021 13:00:57 +0000 >Subject: [PATCH] Bug 29554: Do not hide display of itemtypes on neworderempty >Content-Type: text/plain; charset=utf-8 > >Hiding them may lead to biblioitems.itemtype==NULL. >We do not want that, since 942$c is mandatory. > >Test plan: >Create basket, create order from new empty record. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > acqui/neworderempty.pl | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl >index 22c7c3c04f..7a62d2c04b 100755 >--- a/acqui/neworderempty.pl >+++ b/acqui/neworderempty.pl >@@ -365,9 +365,8 @@ if ($basketobj->effective_create_items eq 'ordering' && !$ordernumber) { > ); > } > >-# Get the item types list, but only if item_level_itype is YES. Otherwise, it will be in the item, no need to display it in the biblio > my @itemtypes; >-@itemtypes = Koha::ItemTypes->search unless C4::Context->preference('item-level_itypes'); >+@itemtypes = Koha::ItemTypes->search; > > if ( defined $from_subscriptionid ) { > # Get the last received order for this subscription >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29554
:
127927
|
139117
|
140688
|
140701
|
141488
|
141873