Attachment 127931 Details for Bug 29524 – Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes

[patch] Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes

Bug-29524-bug-28935-follow-up-Restore-modification.patch (text/plain), 1.97 KB, created by Owen Leonard on 2021-11-22 14:27:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2021-11-22 14:27:42 UTC

Size: 1.97 KB

patch

obsolete

>From ec6cb299e78e79ff4010c9e2d9530b4f9545dc68 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 22 Nov 2021 14:24:40 +0100
>Subject: [PATCH] Bug 29524: (bug 28935 follow-up) Restore modification of some
> patron's attributes
>
>On
>  commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3
>  Bug 28935: No filtering on patron's data on member entry pages
>we restricted the list of the columns from the borrowers table that can
>be modified from the patron edit view.
>We were too restrictive, the following 3 attributes can be edited from
>this form: privacy_guarantor_fines, privacy_guarantor_checkouts,
>checkprevcheckout and lang
>
>Test plan:
>Turn on the following prefs:
>- AllowStaffToSetFinesVisibilityForGuarantor
>- AllowStaffToSetCheckoutsVisibilityForGuarantor
>- CheckPrevCheckout (set to 'unless overridden *')
>- TranslateNotices
>Edit a patron and see the 4 different options are now displayed.
>Change their value, save, edit again
>Confirm that the values have been saved
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> members/memberentry.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index 50c86a4c13..38f2a2b149 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -216,7 +216,7 @@ if ( $op eq 'insert' || $op eq 'modify' || $op eq 'save' || $op eq 'duplicate' )
> # remove keys from %newdata that is not part of patron's attributes
> {
>     my @keys_to_delete = (
>-        qr/^(borrowernumber|date_renewed|debarred|debarredcomment|flags|privacy|privacy_guarantor_fines|privacy_guarantor_checkouts|checkprevcheckout|updated_on|lastseen|lang|login_attempts|overdrive_auth_token|anonymized)$/, # Bug 28935
>+        qr/^(borrowernumber|date_renewed|debarred|debarredcomment|flags|privacy|updated_on|lastseen|login_attempts|overdrive_auth_token|anonymized)$/, # Bug 28935
>         qr/^BorrowerMandatoryField$/,
>         qr/^category_type$/,
>         qr/^check_member$/,
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29524: 127928 | 127931 | 127935