Attachment 127943 Details for Bug 29495 – Bug 29495: (follow-up) Use 'item' relationship

[patch] Bug 29495: (follow-up) Use 'item' relationship

Bug-29495-follow-up-Use-item-relationship.patch (text/plain), 2.09 KB, created by Martin Renvoize (ashimema) on 2021-11-22 18:00:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-11-22 18:00:53 UTC

Size: 2.09 KB

patch

obsolete

>From 1af160ef3d20098e70ef364de070751fdf695e24 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 18 Nov 2021 15:47:02 +0000
>Subject: [PATCH] Bug 29495: (follow-up) Use 'item' relationship
>
>This patch adds the missing 'item' relationship in
>Checkouts::ReturnClaim and then uses it from the resolve method.
>
>This improve the reliability of the resolution code so it works when the
>item has already been checked in (without having to check
>Old::Checkouts).
>---
> Koha/Checkouts/ReturnClaim.pm     | 16 +++++++++++++++-
> Koha/Schema/Result/ReturnClaim.pm | 15 +++++++++++++++
> 2 files changed, 30 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/Checkouts/ReturnClaim.pm b/Koha/Checkouts/ReturnClaim.pm
>index c57a8c05c0..fc49eeb3ad 100644
>--- a/Koha/Checkouts/ReturnClaim.pm
>+++ b/Koha/Checkouts/ReturnClaim.pm
>@@ -102,6 +102,20 @@ sub patron {
>     return Koha::Patron->_new_from_dbic( $borrower ) if $borrower;
> }
> 
>+=head3 item
>+
>+  my $item = $claim->item;
>+
>+Return the return claim item
>+
>+=cut
>+
>+sub item {
>+    my ( $self ) = @_;
>+    my $item_rs = $self->_result->item;
>+    return Koha::Item->_new_from_dbic( $item_rs );
>+}
>+
> =head3 resolve
> 
>     $claim->resolve(
>@@ -138,7 +152,7 @@ sub resolve {
>             )->store;
> 
>             if ( defined $params->{new_lost_status} ) {
>-                $self->checkout->item->itemlost( $params->{new_lost_status} )->store;
>+                $self->item->itemlost( $params->{new_lost_status} )->store;
>             }
>         }
>     );
>diff --git a/Koha/Schema/Result/ReturnClaim.pm b/Koha/Schema/Result/ReturnClaim.pm
>index 4e2c56c40b..9e67c7f0e7 100644
>--- a/Koha/Schema/Result/ReturnClaim.pm
>+++ b/Koha/Schema/Result/ReturnClaim.pm
>@@ -316,6 +316,21 @@ __PACKAGE__->belongs_to(
>     },
> );
> 
>+=head2 item
>+
>+Type: belongs_to
>+
>+Related object: L<Koha::Schema::Result::Item>
>+
>+=cut
>+
>+__PACKAGE__->belongs_to(
>+  "item",
>+  "Koha::Schema::Result::Item",
>+  { itemnumber => "itemnumber" },
>+  { is_deferrable => 1, on_delete => "CASCADE", on_update => "CASCADE" },
>+);
>+
> sub koha_objects_class {
>     'Koha::Checkouts::ReturnClaims';
> }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29495: 127711 | 127712 | 127713 | 127714 | 127765 | 127766 | 127767 | 127768 | 127769 | 127809 | 127810 | 127811 | 127812 | 127813 | 127937 | 127938 | 127939 | 127940 | 127941 | 127942 | 127943 | 127944 | 129105 | 129106 | 129107 | 129109 | 129110 | 129111 | 129112 | 129113 | 129547 | 129575 | 129582 | 130460 | 130461 | 130462 | 130463 | 130464 | 130465 | 130466 | 130467 | 130752 | 130753 | 130754 | 130755 | 130756 | 130757 | 130758