Bugzilla – Attachment 12798 Details for
Bug 8914
Blank search that returns invalid authorities fails under Plack
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8914: Blank search that returns invalid authorities fails under Plack
Bug-8914-Blank-search-that-returns-invalid-authori.patch (text/plain), 1.77 KB, created by
Jared Camins-Esakov
on 2012-10-13 02:50:24 UTC
(
hide
)
Description:
Bug 8914: Blank search that returns invalid authorities fails under Plack
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2012-10-13 02:50:24 UTC
Size:
1.77 KB
patch
obsolete
>From 6ffa614e9f8ddf66ed3ecd2099ecd7d0bb8edacb Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Fri, 12 Oct 2012 22:49:07 -0400 >Subject: [PATCH] Bug 8914: Blank search that returns invalid authorities > fails under Plack > >When doing a search with no terms for the default authority type under >Plack, you will get a segfault if it returns any records that do not >have any authority type. As far as I can tell, this cannot be reproduced >under CGI/Apache. > >To test: >Confirm that you don't get an error if you click the Submit button in >the authorities sections in the staff client and OPAC without entering >a term or changing the authority type. > >You may or may not be able to reproduce the problem prior to applying >the patch, but that is the only situation in which I managed to trigger >it. >--- > C4/AuthoritiesMarc.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm >index 2671cd4..52a298e 100644 >--- a/C4/AuthoritiesMarc.pm >+++ b/C4/AuthoritiesMarc.pm >@@ -359,9 +359,9 @@ sub SearchAuthorities { > } > } > my $thisauthtype = GetAuthType(GetAuthTypeCode($authid)); >+ $thisauthtype |= GetAuthType($authtypecode) if $authtypecode; > $newline{authtype} = defined ($thisauthtype) ? >- $thisauthtype->{'authtypetext'} : >- (GetAuthType($authtypecode) ? $_->{'authtypetext'} : ''); >+ $thisauthtype->{'authtypetext'} : ''; > $newline{summary} = $summary; > $newline{even} = $counter % 2; > $newline{reported_tag} = $reported_tag; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8914
:
12798
|
12895