Bugzilla – Attachment 128040 Details for
Bug 29575
Add a JS render function equivalent of the patron-title.inc TT include
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29575: (QA follow-up) Patron fields can be empty strings
Bug-29575-QA-follow-up-Patron-fields-can-be-empty-.patch (text/plain), 1.50 KB, created by
Martin Renvoize (ashimema)
on 2021-11-26 13:16:47 UTC
(
hide
)
Description:
Bug 29575: (QA follow-up) Patron fields can be empty strings
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-11-26 13:16:47 UTC
Size:
1.50 KB
patch
obsolete
>From cef71de7bcf7248347d61dcc7fc40f7e050eaea1 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 25 Nov 2021 12:33:34 +0000 >Subject: [PATCH] Bug 29575: (QA follow-up) Patron fields can be empty strings > >We need to account for empty strings as well as 'null' values in the >patron data structure. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc >index 3df91d35b2..ea9ff6b683 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc >@@ -15,7 +15,7 @@ > } > > var title = null; >- if ( patron.title != null ) { >+ if ( patron.title != null && patron.title != '' ) { > title = '<span class="patron-title">' + escape_str(patron.title) + '</span>'; > } > >@@ -23,7 +23,7 @@ > var firstname = escape_str(patron.firstname); > var surname = escape_str(patron.surname); > >- if ( patron.other_name != null ) { >+ if ( patron.other_name != null && patron.other_name != '' ) { > firstname += ' (' + escape_str(patron.other_name) + ')'; > } > if ( config && config.invert_name ) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29575
:
127999
|
128000
|
128004
|
128006
|
128038
|
128039
| 128040 |
128639