Bugzilla – Attachment 128062 Details for
Bug 28705
Renewal should look at current article requests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28705: New preference CheckArticleRequestsOnRenewal
Bug-28705-New-preference-CheckArticleRequestsOnRen.patch (text/plain), 3.76 KB, created by
Martin Renvoize (ashimema)
on 2021-11-29 10:27:26 UTC
(
hide
)
Description:
Bug 28705: New preference CheckArticleRequestsOnRenewal
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-11-29 10:27:26 UTC
Size:
3.76 KB
patch
obsolete
>From 00dfc938c9ef0fcff382e56a16db2a7947a2bb16 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 26 Jul 2021 12:15:56 +0000 >Subject: [PATCH] Bug 28705: New preference CheckArticleRequestsOnRenewal > >Test plan: >Run dbrev, check preferences. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > installer/data/mysql/atomicupdate/bug_28705.perl | 9 +++++++++ > installer/data/mysql/mandatory/sysprefs.sql | 1 + > .../prog/en/modules/admin/preferences/circulation.pref | 6 ++++++ > 3 files changed, 16 insertions(+) > create mode 100644 installer/data/mysql/atomicupdate/bug_28705.perl > >diff --git a/installer/data/mysql/atomicupdate/bug_28705.perl b/installer/data/mysql/atomicupdate/bug_28705.perl >new file mode 100644 >index 0000000000..f29684aba5 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_28705.perl >@@ -0,0 +1,9 @@ >+$DBversion = 'XXX'; # will be replaced by the RM >+if( CheckVersion( $DBversion ) ) { >+ $dbh->do(q| >+ INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES >+ ('CheckArticleRequestsOnRenewal', '0', NULL, 'Consider article requests in renewal decision', 'YesNo') >+ |); >+ # Always end with this (adjust the bug info) >+ NewVersion( $DBversion, 28705, "New preference CheckArticleRequestsOnRenewal"); >+} >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index 68877bbbce..ce4809dcac 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -126,6 +126,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('CatalogModuleRelink','0',NULL,'If OFF the linker will never replace the authids that are set in the cataloging module.','YesNo'), > ('CataloguingLog','1',NULL,'If ON, log edit/create/delete actions on bibliographic data. WARNING: this feature is very resource consuming.','YesNo'), > ('ChargeFinesOnClosedDays','0',NULL,'Charge fines on days the library is closed.','YesNo'), >+('CheckArticleRequestsOnRenewal', '0', NULL, 'Consider article requests in renewal decision', 'YesNo'), > ('CheckPrevCheckout','hardno','hardyes|softyes|softno|hardno','By default, for every item checked out, should we warn if the patron has borrowed that item in the past?','Choice'), > ('CheckPrevCheckoutDelay','0', NULL,'Maximum number of days that will trigger a warning if the patron has borrowed that item in the past when CheckPrevCheckout is enabled.','free'), > ('CircAutoPrintQuickSlip','qslip',NULL,'Choose what should happen when an empty barcode field is submitted in circulation: Display a print quick slip window, Display a print slip window or Clear the screen.','Choice'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index 6c2a33bc6c..236ad3b8e7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -1245,6 +1245,12 @@ Circulation: > - "The following article request formats are supported:" > - pref: ArticleRequestsSupportedFormats > - "(Valid choices are currently: PHOTOCOPY and SCAN. Separate the supported formats by a vertical bar. The first listed format is selected by default when you request via the OPAC.)" >+ - >+ - pref: CheckArticleRequestsOnRenewal >+ choices: >+ 0: Do not allow >+ 1: Allow >+ - current article requests to block renewal of an item. For article requests on biblio level, renewal is possible only when another item is available. > > Return claims: > - >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28705
:
122840
|
123190
|
123191
|
128061
| 128062