Attachment 128064 Details for Bug 28617 – Bug 28617: (QA follow-up) Restore FindBin in two places

[patch] Bug 28617: (QA follow-up) Restore FindBin in two places

Bug-28617-QA-follow-up-Restore-FindBin-in-two-plac.patch (text/plain), 1.19 KB, created by Martin Renvoize (ashimema) on 2021-11-29 10:32:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-11-29 10:32:51 UTC

Size: 1.19 KB

patch

obsolete

>From 102095db08d0ff92a38f6cbb4e25fbb93b8696ee Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 22 Nov 2021 09:51:53 +0000
>Subject: [PATCH] Bug 28617: (QA follow-up) Restore FindBin in two places
>
>Resolving:
>    Name "FindBin::Bin" used only once: possible typo
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> misc/migration_tools/bulkmarcimport.pl | 1 +
> xt/yaml_valid.t                        | 1 +
> 2 files changed, 2 insertions(+)
>
>diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl
>index 897e5a7ad0..63409e7964 100755
>--- a/misc/migration_tools/bulkmarcimport.pl
>+++ b/misc/migration_tools/bulkmarcimport.pl
>@@ -32,6 +32,7 @@ use Time::HiRes qw( gettimeofday );
> use Getopt::Long qw( GetOptions );
> use IO::File;
> use Pod::Usage qw( pod2usage );
>+use FindBin ();
> 
> use Koha::Logger;
> use Koha::Biblios;
>diff --git a/xt/yaml_valid.t b/xt/yaml_valid.t
>index b37dbb4eaa..b60d89c6db 100755
>--- a/xt/yaml_valid.t
>+++ b/xt/yaml_valid.t
>@@ -20,6 +20,7 @@
> use Modern::Perl;
> use Test::YAML::Valid;
> use File::Find;
>+use FindBin ();
> 
> use Test::More;
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28617: 122935 | 127916 | 127917 | 128063 | 128064