Attachment 128082 Details for Bug 29592 – Bug 29592: Do not apply defaultvalue to imported record

[patch] Bug 29592: Do not apply defaultvalue to imported record

Bug-29592-Do-not-apply-defaultvalue-to-imported-re.patch (text/plain), 1.35 KB, created by Marcel de Rooy on 2021-11-29 15:06:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-11-29 15:06:47 UTC

Size: 1.35 KB

patch

obsolete

>From c0c031dca8aa0bcc10502581c63bcf2e9f1fc488 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 29 Nov 2021 14:59:13 +0000
>Subject: [PATCH] Bug 29592: Do not apply defaultvalue to imported record
>Content-Type: text/plain; charset=utf-8
>
>The condition breedingid excludes records from Z3950.
>
>Test plan:
>Import to new or existing record. Verify that defaults are not
>applied.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> cataloguing/addbiblio.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
>index 090849da4d..ed2a256a5a 100755
>--- a/cataloguing/addbiblio.pl
>+++ b/cataloguing/addbiblio.pl
>@@ -288,9 +288,9 @@ sub create_input {
>     
>     my $index_subfield = CreateKey(); # create a specifique key for each subfield
> 
>-    # Apply optional framework default value when it is a new record
>+    # Apply optional framework default value when it is a new record (and not an import)
>     # Substitute date parts, user name
>-    if ( $value eq '' && !$cgi->param('biblionumber') ) {
>+    if ( $value eq '' && !$cgi->param('biblionumber') && !$cgi->param('breedingid') ) {
>         $value = $tagslib->{$tag}->{$subfield}->{defaultvalue} // q{};
> 
>         # get today date & replace <<YYYY>>, <<YY>>, <<MM>>, <<DD>> if provided in the default value
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29592: 128082 | 128083 | 131149 | 131150