Attachment 128102 Details for Bug 29588 – Bug 29588: (bug 29478 follow-up) Make strings translatable

[patch] Bug 29588: (bug 29478 follow-up) Make strings translatable

Bug-29588-bug-29478-follow-up-Make-strings-transla.patch (text/plain), 1.73 KB, created by Jonathan Druart on 2021-11-30 11:10:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-11-30 11:10:45 UTC

Size: 1.73 KB

patch

obsolete

>From 1cf3ac9fca445a98282205096493dacfe7ed03bd Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 30 Nov 2021 12:07:02 +0100
>Subject: [PATCH] Bug 29588: (bug 29478 follow-up) Make strings translatable
>
>"or", "Yesterday", "Today" and "Tomorrow" are not translatable, we are
>using __ when _ should be used (__ is for .js files only).
>
>Test plan:
>0. Apply the patch
>1. cd misc/translator && perl translate update fr-FR
>2. Edit misc/translator/po/fr-FR-staff-prog.po
>Search for "or", "Yesterday", "Today" and "Tomorrow" and translate them
>3. cd misc/translator && perl translate install fr-FR
>4. Enable fr-FR (syspref 'language')
>5. Edit a patron and an item and confirm that the flatpickr widget has
>the strings correctly translated
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
>index 2805870d10a..83608902417 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
>@@ -89,16 +89,16 @@
>           ShortcutButtonsPlugin({
>             button: [
>               {
>-                label: __("Yesterday")
>+                label: _("Yesterday")
>               },
>               {
>-                label: __("Today")
>+                label: _("Today")
>               },
>               {
>-                label: __("Tomorrow")
>+                label: _("Tomorrow")
>               }
>             ],
>-            label: __("or"),
>+            label: _("or"),
>             onClick: (index, fp) => {
>               let date;
>               let hh = 23, mm = 59;
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 29588: 128102 | 128121 | 128126 | 128509