Bugzilla – Attachment 12813 Details for
Bug 8769
Allow SIP2 return backdating
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8769 - Allow SIP2 return backdating
Bug-8769---Allow-SIP2-return-backdating.patch (text/plain), 2.17 KB, created by
Kyle M Hall (khall)
on 2012-10-15 12:52:01 UTC
(
hide
)
Description:
Bug 8769 - Allow SIP2 return backdating
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2012-10-15 12:52:01 UTC
Size:
2.17 KB
patch
obsolete
>From 1bc644c01730fbb37f274f126b1d6d6adba9db02 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 15 Oct 2012 08:15:13 -0400 >Subject: [PATCH] Bug 8769 - Allow SIP2 return backdating >Content-Type: text/plain; charset="utf-8" > >--- > C4/Circulation.pm | 4 ++-- > C4/SIP/ILS/Transaction/Checkin.pm | 9 ++++----- > 2 files changed, 6 insertions(+), 7 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 7485de5..a5b82b3 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1678,7 +1678,7 @@ patron who last borrowed the book. > =cut > > sub AddReturn { >- my ( $barcode, $branch, $exemptfine, $dropbox ) = @_; >+ my ( $barcode, $branch, $exemptfine, $dropbox, $return_date) = @_; > > if ($branch and not GetBranchDetail($branch)) { > warn "AddReturn error: branch '$branch' not found. Reverting to " . C4::Context->userenv->{'branch'}; >@@ -1775,7 +1775,7 @@ sub AddReturn { > ); > } > } >- MarkIssueReturned($borrowernumber, $item->{'itemnumber'}, $circControlBranch, '', $borrower->{'privacy'}); >+ MarkIssueReturned($borrowernumber, $item->{'itemnumber'}, $circControlBranch, $return_date, $borrower->{'privacy'}); > $messages->{'WasReturned'} = 1; # FIXME is the "= 1" right? This could be the borrower hash. > } > >diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm >index 47bd85d..2029a0b 100644 >--- a/C4/SIP/ILS/Transaction/Checkin.pm >+++ b/C4/SIP/ILS/Transaction/Checkin.pm >@@ -46,13 +46,12 @@ sub new { > > sub do_checkin { > my $self = shift; >- my $branch = shift; >- if (!$branch) { >- $branch = 'SIP2'; >- } >+ my $branch = shift || 'SIP2'; >+ my $return_date = shift; >+ > my $barcode = $self->{item}->id; > $debug and warn "do_checkin() calling AddReturn($barcode, $branch)"; >- my ($return, $messages, $iteminformation, $borrower) = AddReturn($barcode, $branch); >+ my ($return, $messages, $iteminformation, $borrower) = AddReturn($barcode, $branch, undef, undef, $return_date); > $self->alert(!$return); > # ignoring messages: NotIssued, IsPermanent, WasLost, WasTransfered > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8769
:
12193
|
12811
|
12812
|
12813
|
15248
|
19999
|
20000
|
21942
|
23698
|
26753
|
27465
|
27466
|
27467
|
27944
|
27945
|
27946