Bugzilla – Attachment 128144 Details for
Bug 28919
When placing a multi-hold from results in staff pickup location is empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28919: [Alternative] Select logged in library as pickup for multi holds
Bug-28919-Alternative-Select-logged-in-library-as-.patch (text/plain), 3.53 KB, created by
David Cook
on 2021-12-02 01:37:11 UTC
(
hide
)
Description:
Bug 28919: [Alternative] Select logged in library as pickup for multi holds
Filename:
MIME Type:
Creator:
David Cook
Created:
2021-12-02 01:37:11 UTC
Size:
3.53 KB
patch
obsolete
>From 11a9afabddca755eceeec94fb65a66a4a318acc5 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 2 Dec 2021 01:35:08 +0000 >Subject: [PATCH] Bug 28919: [Alternative] Select logged in library as pickup > for multi holds > >Default pickup location to the logged in library for staff placed multiholds. > >Holds with a blank pickup location will cause 500 errors in the Reserves >tab of the circulation screen, so we want to make sure the pickup location >does not default to blank. >--- > .../prog/en/modules/reserve/request.tt | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 6ac5cddf12..bd67cdff60 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -467,9 +467,12 @@ > [% PROCESS options_for_libraries libraries => Branches.pickup_locations({ search_params => { biblio => biblionumber, patron => patron }, selected => pickup }) %] > [% ELSE %] > <select name="pickup" id="pickup_multi" data-patron-id="[% patron.borrowernumber | html %]"> >- <option value="" selected="selected"></option> > [% FOREACH pickup_location IN multi_pickup_locations %] >- <option value="[% pickup_location.branchcode | html %]">[% pickup_location.branchname | html %]</option> >+ [% pickup_selected = '' %] >+ [% IF Branches.GetLoggedInBranchcode == pickup_location.branchcode %] >+ [% pickup_selected = 'selected="selected"' %] >+ [% END %] >+ <option [% pickup_selected %] value="[% pickup_location.branchcode | html %]">[% pickup_location.branchname | html %]</option> > [% END %] > [% END %] > </select> >@@ -853,9 +856,12 @@ > data-biblio-id="[% biblioloo.biblionumber | html %]" > data-patron-id="[% patron.borrowernumber | html %]" > data-pickup-locations='[% biblioloo.pickup_locations_codes.json | $raw %]'> >- <option value=""></option> > [% FOREACH pickup_location IN biblioloo.pickup_locations %] >- <option value="[% pickup_location.branchcode | html %]">[% pickup_location.branchname | html %]</option> >+ [% pickup_selected = '' %] >+ [% IF Branches.GetLoggedInBranchcode == pickup_location.branchcode %] >+ [% pickup_selected = 'selected="selected"' %] >+ [% END %] >+ <option [% pickup_selected %] value="[% pickup_location.branchcode | html %]">[% pickup_location.branchname | html %]</option> > [% END %] > </select> > </td> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28919
:
124419
|
125221
|
125658
| 128144