Attachment 128158 Details for Bug 29605 – Bug 29605: branchtransfers.cancellation_reason

[patch] Bug 29605: branchtransfers.cancellation_reason

Bug-29605-branchtransferscancellationreason.patch (text/plain), 3.28 KB, created by Jonathan Druart on 2021-12-02 12:09:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-12-02 12:09:42 UTC

Size: 3.28 KB

patch

obsolete

>From 759cb9f6a4d870644346b6f4af26860978ee43b5 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 2 Dec 2021 12:55:36 +0100
>Subject: [PATCH] Bug 29605: branchtransfers.cancellation_reason
>
>reason and cancellation_reason was inversed, and the enum values were
>lower cases
>---
> .../data/mysql/atomicupdate/bug_29605.pl      | 22 ++++++++++++++++
> installer/data/mysql/db_revs/210600003.pl     | 26 +++++++++----------
> 2 files changed, 35 insertions(+), 13 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_29605.pl b/installer/data/mysql/atomicupdate/bug_29605.pl
>index c1febb47178..3df37615d8e 100755
>--- a/installer/data/mysql/atomicupdate/bug_29605.pl
>+++ b/installer/data/mysql/atomicupdate/bug_29605.pl
>@@ -62,6 +62,28 @@ return {
>         $dbh->do(q{ALTER TABLE search_marc_map MODIFY `marc_type` enum('marc21','unimarc') NOT NULL COMMENT 'what MARC type this map is for'});
>         say $out "Ensure NOT NULL on search_marc_map.marc_type";
> 
>+        $dbh->do(
>+            q{
>+                alter table
>+                    `branchtransfers`
>+                modify column
>+                    `cancellation_reason` enum(
>+                        'Manual',
>+                        'StockrotationAdvance',
>+                        'StockrotationRepatriation',
>+                        'ReturnToHome',
>+                        'ReturnToHolding',
>+                        'RotatingCollection',
>+                        'Reserve',
>+                        'LostReserve',
>+                        'CancelReserve',
>+                        'ItemLost',
>+                        'WrongTransfer'
>+                    ) DEFAULT NULL
>+                after `reason`
>+              }
>+        );
>+        say $out "Ensure branchtransfers.cancellation_reason enum values are uppercase";
>     },
> 
> }
>diff --git a/installer/data/mysql/db_revs/210600003.pl b/installer/data/mysql/db_revs/210600003.pl
>index edaa5807378..e05228a3e85 100755
>--- a/installer/data/mysql/db_revs/210600003.pl
>+++ b/installer/data/mysql/db_revs/210600003.pl
>@@ -14,19 +14,19 @@ use Modern::Perl;
>                     `branchtransfers`
>                 modify column
>                     `cancellation_reason` enum(
>-                        'manual',
>-                        'stockrotationadvance',
>-                        'stockrotationrepatriation',
>-                        'returntohome',
>-                        'returntoholding',
>-                        'rotatingcollection',
>-                        'reserve',
>-                        'lostreserve',
>-                        'cancelreserve',
>-                        'itemlost',
>-                        'wrongtransfer'
>-                    )
>-                after `comments`
>+                        'Manual',
>+                        'StockrotationAdvance',
>+                        'StockrotationRepatriation',
>+                        'ReturnToHome',
>+                        'ReturnToHolding',
>+                        'RotatingCollection',
>+                        'Reserve',
>+                        'LostReserve',
>+                        'CancelReserve',
>+                        'ItemLost',
>+                        'WrongTransfer'
>+                    ) DEFAULT NULL
>+                after `reason`
>               }
>         );
>     },
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 29605: 128113 | 128114 | 128152 | 128153 | 128154 | 128155 | 128156 | 128157 | 128158 | 128239 | 128313 | 128314 | 128437 | 128438 | 128439 | 128440 | 128441 | 128442 | 128443 | 128444 | 128445 | 128483 | 129153 | 129154 | 129155 | 129156 | 129157 | 129158 | 129159 | 129160 | 129161