Bugzilla – Attachment 128188 Details for
Bug 29628
Purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29628: Show purchase suggestion link when there are any suggestions systemwide
Bug-29628-Show-purchase-suggestion-link-when-there.patch (text/plain), 3.24 KB, created by
Lucas Gass (lukeg)
on 2021-12-03 00:59:03 UTC
(
hide
)
Description:
Bug 29628: Show purchase suggestion link when there are any suggestions systemwide
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2021-12-03 00:59:03 UTC
Size:
3.24 KB
patch
obsolete
>From 0db9e8b5ecc7794600b3fc9476b77af3a5a2bab5 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 3 Dec 2021 00:51:07 +0000 >Subject: [PATCH] Bug 29628: Show purchase suggestion link when there are any > suggestions systemwide > >To test: >1. Make some purchase suggestions at different branches. >2. Log in to a branch with a suggestion and visit /cgi-bin/koha/mainpage.pl >3. See something like: Suggestions pending approval: Centerville: 1 / All libraries: 2 >4. Log into a branch with no suggestions, no link about suggestions >5. Apply patch >6. Repeat step 2, and still see something like: Centerville: 1 / All libraries: 2 >7. Try a branch with no suggestions, now you see a link like: Centerville: 0 / All libraries: 2 >--- > koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt >index cf7f0300e3..6978be0f68 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt >@@ -165,7 +165,7 @@ > <div class="row"> > <div class="col-sm-12"> > [%# Following statement must be in one line for translatability %] >- [% IF ( CAN_user_tools_moderate_comments && pendingcomments ) || ( CAN_user_tools_moderate_tags && pendingtags ) || ( CAN_user_borrowers_edit_borrowers && pending_borrower_modifications ) || ( CAN_user_suggestions_suggestions_manage && pendingsuggestions ) || ( CAN_user_borrowers_edit_borrowers && pending_discharge_requests ) || pending_article_requests || ( Koha.Preference('AllowCheckoutNotes') && CAN_user_circulate_manage_checkout_notes && pending_checkout_notes.count ) || ( Koha.Preference('OPACReportProblem') && CAN_user_problem_reports && pending_problem_reports.count ) || already_ran_jobs %] >+ [% IF ( CAN_user_tools_moderate_comments && pendingcomments ) || ( CAN_user_tools_moderate_tags && pendingtags ) || ( CAN_user_borrowers_edit_borrowers && pending_borrower_modifications ) || ( CAN_user_suggestions_suggestions_manage && all_pendingsuggestions ) || ( CAN_user_borrowers_edit_borrowers && pending_discharge_requests ) || pending_article_requests || ( Koha.Preference('AllowCheckoutNotes') && CAN_user_circulate_manage_checkout_notes && pending_checkout_notes.count ) || ( Koha.Preference('OPACReportProblem') && CAN_user_problem_reports && pending_problem_reports.count ) || already_ran_jobs %] > <div id="area-pending"> > [% IF pending_article_requests %] > <div class="pending-info" id="article_requests_pending"> >@@ -175,7 +175,7 @@ > </div> > [% END %] > >- [% IF ( CAN_user_suggestions_suggestions_manage && pendingsuggestions ) %] >+ [% IF ( CAN_user_suggestions_suggestions_manage && all_pendingsuggestions ) %] > <div class="pending-info" id="suggestions_pending"> > > Suggestions pending approval: >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29628
:
128188
|
128220
|
128242
|
128243