Attachment 128229 Details for Bug 27801 – Bug 27801: Fix javascript price calculations

[patch] Bug 27801: Fix javascript price calculations

Bug-27801-Fix-javascript-price-calculations.patch (text/plain), 1.41 KB, created by Martin Renvoize (ashimema) on 2021-12-03 15:32:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-12-03 15:32:45 UTC

Size: 1.41 KB

patch

obsolete

>From 4bbcdbf03b2ec3d2f83d496cda8e2222c8c52c5f Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 3 Dec 2021 15:29:00 +0000
>Subject: [PATCH] Bug 27801: Fix javascript price calculations
>
>This patch ensures we're formatting the price values consistently for
>the table total and the amount to pay input field.
>
>Test plan
>1) Add an item to charge at 0.10.
>2) Add this same item 8 or 9 times (Do not use the 'quantity')
>3) Note that the table total and the 'Amount paid' values do not match
>4) Apply the patch and repeat the above steps.. the values should now
>   match.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>index cab264b802..243c0baaae 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>@@ -342,7 +342,8 @@
>                 {
>                     iTotalPrice += aData[i][3]*1;
>                 }
>-                nFoot.getElementsByTagName('td')[1].innerHTML = iTotalPrice.format_price();
>+                iTotalPrice = iTotalPrice.format_price();
>+                nFoot.getElementsByTagName('td')[1].innerHTML = iTotalPrice;
>                 $('#paid').val(iTotalPrice);
>                 $('#paid').trigger('change');
>             },
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27801: 125287 | 128228 | 128229 | 128234 | 128358 | 128449