Bugzilla – Attachment 128232 Details for
Bug 29637
AutoSwitchPatron is broken since Bug 26352
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Bug-29637-AutoSwitchPatron-should-look-for-card-numb.patch (text/plain), 1.51 KB, created by
Michael Hafen
on 2021-12-03 18:47:20 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Michael Hafen
Created:
2021-12-03 18:47:20 UTC
Size:
1.51 KB
patch
obsolete
>From 4cfb2eb4c92542d4e04659e1ed386e18a4bfafd0 Mon Sep 17 00:00:00 2001 >From: Michael Hafen <michael.hafen@washk12.org> >Date: Fri, 3 Dec 2021 11:43:16 -0700 >Subject: [PATCH] Bug 29637: AutoSwitchPatron should look for card number in > the barcode >Content-Type: text/plain; charset="utf-8" > >Bug 26352 changed the line in circ/circulation.pl that searches for a >patron card number in the barcode field from using the $barcode variable >to the $findborrower variable. This breaks AutoSwitchPatron. > >Test plan: > >1. make sure AutoSwitchPatron system preference is on. >2. get two patron card numbers. >3. enter the first card number to check out to the patron. >4. enter the second card number in the item barcode field. >5. observe that the barcode is not found. > >6. apply patch > >7. enter the second card number in the item barcode field again. >8. observe that the second patron is loaded to check out to. >--- > circ/circulation.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index 89ccf2a765..705ac45ac5 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -76,7 +76,7 @@ my $autoswitched; > my $borrowernumber = $query->param('borrowernumber'); > > if (C4::Context->preference("AutoSwitchPatron") && $barcode) { >- my $new_barcode = $findborrower; >+ my $new_barcode = $barcode; > Koha::Plugins->call( 'patron_barcode_transform', \$new_barcode ); > if (Koha::Patrons->search( { cardnumber => $new_barcode} )->count() > 0) { > $findborrower = $barcode; >-- >2.25.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29637
:
128232
|
128240
|
128275