Attachment 128240 Details for Bug 29637 – Bug 29637: AutoSwitchPatron should look for card number in the barcode

[patch] Bug 29637: AutoSwitchPatron should look for card number in the barcode

Bug-29637-AutoSwitchPatron-should-look-for-card-nu.patch (text/plain), 1.51 KB, created by David Nind on 2021-12-04 02:51:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-12-04 02:51:36 UTC

Size: 1.51 KB

patch

obsolete

>From c7a9ea15ab28b2bd4a4856426517f8da6b898398 Mon Sep 17 00:00:00 2001
>From: Michael Hafen <michael.hafen@washk12.org>
>Date: Fri, 3 Dec 2021 11:43:16 -0700
>Subject: [PATCH] Bug 29637: AutoSwitchPatron should look for card number in
> the barcode
>
>Bug 26352 changed the line in circ/circulation.pl that searches for a
>patron card number in the barcode field from using the $barcode variable
>to the $findborrower variable.  This breaks AutoSwitchPatron.
>
>Test plan:
>
>1. make sure AutoSwitchPatron system preference is on.
>2. get two patron card numbers.
>3. enter the first card number to check out to the patron.
>4. enter the second card number in the item barcode field.
>5. observe that the barcode is not found.
>
>6. apply patch
>
>7. enter the second card number in the item barcode field again.
>8. observe that the second patron is loaded to check out to.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> circ/circulation.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/circ/circulation.pl b/circ/circulation.pl
>index 89ccf2a765..705ac45ac5 100755
>--- a/circ/circulation.pl
>+++ b/circ/circulation.pl
>@@ -76,7 +76,7 @@ my $autoswitched;
> my $borrowernumber = $query->param('borrowernumber');
> 
> if (C4::Context->preference("AutoSwitchPatron") && $barcode) {
>-    my $new_barcode = $findborrower;
>+    my $new_barcode = $barcode;
>     Koha::Plugins->call( 'patron_barcode_transform', \$new_barcode );
>     if (Koha::Patrons->search( { cardnumber => $new_barcode} )->count() > 0) {
>         $findborrower = $barcode;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29637: 128232 | 128240 | 128275